Skip to content
This repository has been archived by the owner on Nov 12, 2022. It is now read-only.

Remove the use of unstable Rust features. #373

Merged
merged 2 commits into from
Oct 16, 2017
Merged

Remove the use of unstable Rust features. #373

merged 2 commits into from
Oct 16, 2017

Conversation

SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Oct 14, 2017

This modifies generated files, but http://searchfox.org/mozilla-central/source/js/rust/ already has similar changes through rust_target(bindgen::RustTarget::Stable_1_19)

This depends on servo/servo#18875.


This change is Reviewable

This modifies generated files, but
http://searchfox.org/mozilla-central/source/js/rust/ already has
similar changes through `rust_target(bindgen::RustTarget::Stable_1_19)`
@SimonSapin
Copy link
Member Author

Homebrew is unhappy on Travis:

/usr/local/Homebrew/Library/Homebrew/brew.rb:12:in `<main>': Homebrew must be run under Ruby 2.3! (RuntimeError)

The command "if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then brew install ccache yasm; fi" failed and exited with 1 during .

@jdm
Copy link
Member

jdm commented Oct 16, 2017

@bors-servo: r+

@bors-servo
Copy link
Contributor

📌 Commit 2b54c6d has been approved by jdm

@bors-servo
Copy link
Contributor

⌛ Testing commit 2b54c6d with merge fdcc7a0...

bors-servo pushed a commit that referenced this pull request Oct 16, 2017
Remove the use of unstable Rust features.

This modifies generated files, but http://searchfox.org/mozilla-central/source/js/rust/ already has similar changes through `rust_target(bindgen::RustTarget::Stable_1_19)`

This depends on servo/servo#18875.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/373)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: jdm
Pushing fdcc7a0 to master...

@bors-servo bors-servo merged commit 2b54c6d into master Oct 16, 2017
@SimonSapin SimonSapin deleted the stable branch October 16, 2017 17:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants