Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the use of unstable Rust features. #373

Merged
merged 2 commits into from Oct 16, 2017
Merged

Remove the use of unstable Rust features. #373

merged 2 commits into from Oct 16, 2017

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Oct 14, 2017

This modifies generated files, but http://searchfox.org/mozilla-central/source/js/rust/ already has similar changes through rust_target(bindgen::RustTarget::Stable_1_19)

This depends on servo/servo#18875.


This change is Reviewable

This modifies generated files, but
http://searchfox.org/mozilla-central/source/js/rust/ already has
similar changes through `rust_target(bindgen::RustTarget::Stable_1_19)`
@SimonSapin SimonSapin force-pushed the stable branch from 797441b to cdb9570 Oct 14, 2017
@SimonSapin
Copy link
Member Author

SimonSapin commented Oct 14, 2017

Homebrew is unhappy on Travis:

/usr/local/Homebrew/Library/Homebrew/brew.rb:12:in `<main>': Homebrew must be run under Ruby 2.3! (RuntimeError)

The command "if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then brew install ccache yasm; fi" failed and exited with 1 during .
@jdm
Copy link
Member

jdm commented Oct 16, 2017

@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2017

📌 Commit 2b54c6d has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2017

Testing commit 2b54c6d with merge fdcc7a0...

bors-servo added a commit that referenced this pull request Oct 16, 2017
Remove the use of unstable Rust features.

This modifies generated files, but http://searchfox.org/mozilla-central/source/js/rust/ already has similar changes through `rust_target(bindgen::RustTarget::Stable_1_19)`

This depends on servo/servo#18875.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/373)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 16, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: jdm
Pushing fdcc7a0 to master...

@bors-servo bors-servo merged commit 2b54c6d into master Oct 16, 2017
5 checks passed
5 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the stable branch Oct 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.