Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo bench broken on Travis #44

Closed
jdm opened this issue Mar 22, 2017 · 3 comments
Closed

cargo bench broken on Travis #44

jdm opened this issue Mar 22, 2017 · 3 comments

Comments

@jdm
Copy link
Member

jdm commented Mar 22, 2017

From travis:

     Running `rustc --crate-name bench benches/bench.rs --emit=dep-info,link -C opt-level=3 --test -C metadata=6041378d75069d53 -C extra-filename=-6041378d75069d53 --out-dir /home/travis/build/servo/rust-smallvec/target/release/deps -L dependency=/home/travis/build/servo/rust-smallvec/target/release/deps --extern smallvec=/home/travis/build/servo/rust-smallvec/target/release/deps/libsmallvec-ad2736f846965482.rlib`

error[E0554]: #[feature] may not be used on the stable release channel

 --> benches/bench.rs:1:1

  |

1 | #![feature(test)]

  | ^^^^^^^^^^^^^^^^^

error: aborting due to previous error

error: Could not compile `smallvec`.

Caused by:

  process didn't exit successfully: `rustc --crate-name bench benches/bench.rs --emit=dep-info,link -C opt-level=3 --test -C metadata=6041378d75069d53 -C extra-filename=-6041378d75069d53 --out-dir /home/travis/build/servo/rust-smallvec/target/release/deps -L dependency=/home/travis/build/servo/rust-smallvec/target/release/deps --extern smallvec=/home/travis/build/servo/rust-smallvec/target/release/deps/libsmallvec-ad2736f846965482.rlib` (exit code: 101)

Build failed, waiting for other jobs to finish...

error: build failed

The command "cargo build --verbose &&

cargo build --features=heapsizeof --verbose &&

cargo test --verbose &&

cargo test --features=heapsizeof --verbose &&

([ $TRAVIS_RUST_VERSION != nightly ] || cargo bench --verbose bench)

" exited with 101.
@mbrubeck
Copy link
Collaborator

The travis script should already do this, but its check seems to be broken, maybe related to travis-ci/travis-build#993 which just landed.

mbrubeck added a commit to mbrubeck/rust-smallvec that referenced this issue Mar 22, 2017
mbrubeck added a commit to mbrubeck/rust-smallvec that referenced this issue Mar 22, 2017
bors-servo pushed a commit that referenced this issue Mar 22, 2017
Temporarily disable `cargo bench` because of #44.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-smallvec/46)
<!-- Reviewable:end -->
@mbrubeck
Copy link
Collaborator

I temporarily disabled cargo bench. We should re-enable it after the Travis issue is fixed.

mbrubeck added a commit to mbrubeck/rust-smallvec that referenced this issue Mar 23, 2017
@mbrubeck
Copy link
Collaborator

Fixed by travis-ci/travis-ci#7510.

@mbrubeck mbrubeck changed the title Remove benchmark feature in stable builds cargo bench broken on Travis Mar 23, 2017
bors-servo pushed a commit that referenced this issue Mar 23, 2017
Re-enable cargo bench on Travis

This reverts commit 0586430 which disabled `cargo bench` on Travis because of #44  which is now fixed.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-smallvec/47)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants