Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upModify `define_encode_set` to support private definitions #307
Comments
brson
added
the
help wanted
label
May 4, 2017
This comment has been minimized.
This comment has been minimized.
|
As discussed in #298 (comment) this is a very niche feature, so extending it seems low value. In particular it doesn’t seem worth adding new APIs and deprecating old ones, to me. |
This comment has been minimized.
This comment has been minimized.
|
@SimonSapin ok, sgtm. |
brson
closed this
May 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
brson commentedMay 4, 2017
Right now all encode sets must be explicitly
pub. Generally such macros should have a grammar that accepts non-pub definitions.It doesn't look like the existing grammar supports this extension though:
There's no other keyword there besides
pub. Seems like this definition would be better if you had to type likepub struct QUERY_ENCODE_SET.So fixing this might require adding two rules and basically deprecating the existing rule? Not sure.