Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upDocument the percent_encoding module #298
Comments
brson
added
the
help wanted
label
May 4, 2017
This comment has been minimized.
This comment has been minimized.
If one doesn’t know whether they need a custom encode set, they probably don’t. This a fairly advanced feature, almost an "escape hatch". While it should be documented in the sense that everything should be documented, it shouldn’t be featured prominently in the module’s or crate’s documentation. I wish rustdoc was prose-oriented like Sphinx, and let crate authors/maintainers choose what items to show first and generally how to organize docs. |
SimonSapin
referenced this issue
May 5, 2017
Closed
Modify `define_encode_set` to support private definitions #307
AndyGauge
referenced this issue
Jun 8, 2017
Closed
Documentation and examples enhancements of percent encoding #355
bors-servo
added a commit
that referenced
this issue
Jun 13, 2017
bors-servo
closed this
in
#361
Jun 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
brson commentedMay 4, 2017
•
edited
This module encapsulates a crate-specific pattern that could be explained better.
Some things that might clarify my questions about this module:
EncodeSet