New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test packaging on android builder #386
Test packaging on android builder #386
Conversation
Removing blocked-on-external as the Android fixes have landed. |
Re-adding the label because there are still other issues that need to be resolved. Looking at the android nightly output, the next issue is fixing the build script to invoke |
Our android-nightly builder has been busted for a long time, which meant our packaging code was not being exercised. Also, the nightly builder only runs once a day instead of on each build, which recently allowed a regression to slip in due to an uncaught syntax error. To prevent future regressions, test packaging on the android builder, which runs on try and auto builds.
03ec438
to
3501d17
Compare
Updated this PR to use the new |
Next blocker is #401. |
@bors-servo r+ |
📌 Commit 3501d17 has been approved by |
…bergstrom Test packaging on android builder Our android-nightly builder has been busted for a long time, which meant our packaging code was not being exercised. Also, the nightly builder only runs once a day instead of on each build, which recently allowed a regression to slip in due to an uncaught syntax error. To prevent future regressions, test packaging on the android builder, which runs on try and auto builds. See servo/servo#11406 for the bug. This should not be merged until that fix is merged and android-nightly has had a chance to run, to ensure that packaging is no longer broken. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/386) <!-- Reviewable:end -->
☀️ Test successful - travis |
It looks like this change was deployed to |
I thought it was rolled out, but it turned out that I also discovered the dirty bits in |
Our android-nightly builder has been busted for a long time, which meant
our packaging code was not being exercised. Also, the nightly builder
only runs once a day instead of on each build, which recently allowed
a regression to slip in due to an uncaught syntax error. To prevent
future regressions, test packaging on the android builder, which runs
on try and auto builds.
See servo/servo#11406 for the bug.
This should not be merged until that fix is merged and android-nightly has
had a chance to run, to ensure that packaging is no longer broken.
This change is