Mark external menu items with icon #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoburns
force-pushed
the
mark-ext-menu-items
branch
from
8f1c17f to
8ded9b5
Compare
|
Preview link: https://servo.org/mark-ext-menu-items/ |
mrego
approved these changes
Feb 19, 2025
| @@ -0,0 +1 @@ | |||
| <span style="font-size: 0.8em;display:inline-block;margin-left: 4px"><i class="fa-solid fa-up-right-from-square"></i></span> No newline at end of file | |||
There was a problem hiding this comment.
Could we move the style here to the CSS file? Maybe under .navar-link and .navbar-item.
There was a problem hiding this comment.
Not really seeing any advantage to doing that. These styles are never used anywhere else, and they'll get lost in the 1000 line css file. This component (as it exists now) could also be used in places other than the navbar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marks menu items that link out to external content with the standard icon for that:
https://fontawesome.com/v6/icons/up-right-from-square?f=classic&s=solid