Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Node::isSameNode #10746

Closed
Ms2ger opened this issue Apr 20, 2016 · 2 comments
Closed

Implement Node::isSameNode #10746

Ms2ger opened this issue Apr 20, 2016 · 2 comments
Labels
A-content/dom Interacting with the DOM from web content C-assigned There is someone working on resolving the issue E-less-complex Straightforward. Recommended for a new contributor. I-enhancement No impact; the issue is a missing or proposed feature.

Comments

@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 20, 2016 •
edited by jdm
Loading

Blocks #2185.

Fixing this bug will allow you to say you implemented one of the most useless features in the Web platform.
@Ms2ger Ms2ger added A-content/dom Interacting with the DOM from web content E-less-complex Straightforward. Recommended for a new contributor. I-enhancement No impact; the issue is a missing or proposed feature. labels Apr 20, 2016
@amarant
Copy link
Contributor

amarant commented Apr 20, 2016

Can I take this one ?

@jdm
Copy link
Member

jdm commented Apr 20, 2016

Sure :)

@jdm jdm added the C-assigned There is someone working on resolving the issue label Apr 20, 2016
amarant added a commit to amarant/servo that referenced this issue Apr 20, 2016
@amarant
Implements Node::isSameNode
21e3765 
Fixes servo#10746

I adapted the tests from dom/nodes/Node-isEqualNode.html
should I also add ones for xhtml too like here : dom/nodes/Node-isEqualNode-xhtml.xhtml ?
@amarant amarant mentioned this issue Apr 20, 2016
Merged
bors-servo pushed a commit that referenced this issue Apr 21, 2016
Auto merge of #10761 - amarant:Node-isSameNode, r=<try>
8646e6e 
Implements Node::isSameNode

Fixes #10746

I adapted the tests from dom/nodes/Node-isEqualNode.html
should I also add ones for xhtml too like here : dom/nodes/Node-isEqualNode-xhtml.xhtml ?

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10761)
<!-- Reviewable:end -->
amarant added a commit to amarant/servo that referenced this issue Apr 21, 2016
@amarant
Implements Node::isSameNode
dee4d60 
Fixes servo#10746

I adapted the tests from dom/nodes/Node-isEqualNode.html
should I also add ones for xhtml too like here : dom/nodes/Node-isEqualNode-xhtml.xhtml ?
amarant added a commit to amarant/servo that referenced this issue Apr 23, 2016
@amarant
Implements Node::isSameNode
ed42cc7 
Fixes servo#10746

Adapted the tests from dom/nodes/Node-isEqualNode.html
bors-servo pushed a commit that referenced this issue Apr 25, 2016
Auto merge of #10761 - amarant:Node-isSameNode, r=Ms2ger
4f05ea7 
Implements Node::isSameNode

Fixes #10746

I adapted the tests from dom/nodes/Node-isEqualNode.html
should I also add ones for xhtml too like here : dom/nodes/Node-isEqualNode-xhtml.xhtml ?

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10761)
<!-- Reviewable:end -->
jaysonsantos pushed a commit to jaysonsantos/servo that referenced this issue May 12, 2016
@amarant @jaysonsantos
Implements Node::isSameNode
21b44b4 
Fixes servo#10746

Adapted the tests from dom/nodes/Node-isEqualNode.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom Interacting with the DOM from web content C-assigned There is someone working on resolving the issue E-less-complex Straightforward. Recommended for a new contributor. I-enhancement No impact; the issue is a missing or proposed feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jdm @Ms2ger @amarant