Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide unnecessary information in the rendered PR template #11383

Merged
merged 3 commits into from May 26, 2016
Merged

Hide unnecessary information in the rendered PR template #11383

merged 3 commits into from May 26, 2016

Conversation

jdm
Copy link
Member

@jdm jdm commented May 24, 2016 •
edited by larsbergstrom

These changes attempt to make the initial PR view less cluttered. Instructions are hidden in HTML comments, and there's a clear distinction between the PR description and the checklist.

  • ./mach build -d does not report any errors
  • ./mach test-tidy --faster does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because not part of the build

This change is Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label May 24, 2016
mbrubeck
mbrubeck reviewed May 24, 2016
View reviewed changes
PULL_REQUEST_TEMPLATE.md
@@ -1,10 +1,13 @@
Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data:
Replace this paragraph with a description of the changes, then follow the instructions in the next section.
Copy link
Contributor

@mbrubeck mbrubeck May 24, 2016 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should also be a comment that just says "Enter a description of your changes below this line:" (and then some blank space).

(I think that makes it a little harder to gloss over this step.)

@mbrubeck mbrubeck assigned mbrubeck and unassigned Ms2ger May 24, 2016
@aneeshusa
Copy link
Contributor

Same comment as #11340 (comment) - I find that people mostly add their own content at the end of the template instead of at the top.

@jdm
Copy link
Member Author

jdm commented May 24, 2016 •
edited

@aneeshusa While I can believe that, we may be able to influence that decision. I think doing so is useful, since it will address one of @nox's common complaints about the new template.

@aneeshusa
Copy link
Contributor

Works for me, although mbrubeck's suggested change would make it much more natural (having to replace existing text is just weird).

@metajack
Copy link
Contributor

This looks good to me. I think @mbrubeck's suggestion is a good one, but I'm happy to try it this way first if you prefer that. If we see anyone submitting PRs without changing this text, then I think we should definitely make that change.

This is r=me but I didn't r+ it since mbrubeck is the assignee and his suggestion was unaddressed in the comments.

@highfive
Copy link

New code was committed to pull request.

@jdm
Copy link
Member Author

jdm commented May 24, 2016

@mbrubeck See what you think of my newest text.

@mbrubeck
Copy link
Contributor

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 76cba2a has been approved by mbrubeck

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels May 24, 2016
@Ms2ger
Copy link
Contributor

Ms2ger commented May 25, 2016

@bors-servo p=-1

@jdm jdm mentioned this pull request May 25, 2016
Closed
@bors-servo
Copy link
Contributor

☔ The latest upstream changes (presumably #11409) made this pull request unmergeable. Please resolve the merge conflicts.

@highfive highfive added S-needs-rebase There are merge conflict errors. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels May 25, 2016
@metajack
Copy link
Contributor

OMG. How sad that we can bitrot this :)

@jdm jdm closed this May 25, 2016
@highfive
Copy link

New code was committed to pull request.

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label May 25, 2016
@jdm jdm reopened this May 25, 2016
@jdm
Copy link
Member Author

jdm commented May 25, 2016

@bors-servo: r=mbrubeck

@bors-servo
Copy link
Contributor

📌 Commit 1cfc2c9 has been approved by mbrubeck

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. S-needs-rebase There are merge conflict errors. labels May 25, 2016
@jdm
Copy link
Member Author

jdm commented May 25, 2016

@bors-servo: p=-1

@bors-servo
Copy link
Contributor

⌛ Testing commit 1cfc2c9 with merge a2874ef...

bors-servo pushed a commit that referenced this pull request May 26, 2016
Auto merge of #11383 - servo:jdm-patch-1, r=mbrubeck
a2874ef 
Hide unnecessary information in the rendered PR template

These changes attempt to make the initial PR view less cluttered. Instructions are hidden in HTML comments, and there's a clear distinction between the PR description and the checklist.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data:-->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy --faster` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because not part of the build

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11383)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-css

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels May 26, 2016
@mbrubeck
Copy link
Contributor

@bors-servo retry

mac1

@bors-servo
Copy link
Contributor

⌛ Testing commit 1cfc2c9 with merge b898550...

bors-servo pushed a commit that referenced this pull request May 26, 2016
Auto merge of #11383 - servo:jdm-patch-1, r=mbrubeck
b898550 
Hide unnecessary information in the rendered PR template

These changes attempt to make the initial PR view less cluttered. Instructions are hidden in HTML comments, and there's a clear distinction between the PR description and the checklist.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data:-->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy --faster` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because not part of the build

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11383)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels May 26, 2016
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows

@bors-servo bors-servo merged commit 1cfc2c9 into master May 26, 2016
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label May 26, 2016
@nox nox deleted the jdm-patch-1 branch May 28, 2016 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mbrubeck mbrubeck

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jdm @aneeshusa @metajack @highfive @mbrubeck @bors-servo @Ms2ger