Servo displays upper level Thai character in wrong place. #12193

Closed
veer66 opened this Issue Jul 3, 2016 · 3 comments

Projects

None yet

4 participants

@veer66
Contributor
veer66 commented Jul 3, 2016 edited

On Ubuntu 16.04, Servo nightly, that I downloaded on 2016-07-03, displays upper level Thai characters in the incorrect place. Moreover it choose incorrect glyph too.

Update: Servo on Mac OS X 10.11.5. has this issue too.

The text is "ยินดี". It is supposed to display ี on top of ด but it displays ิ on top of น, which is incorrect glyph and incorrect placement.

servo_thai_bug

An URL for the test case is http://file.veerkesto.net/servo_test/simple-thai.html

@khaledhosny

It seems that two different fonts are used here, so it can be a bug in the font selected by Servo. Can you try to use the same font in both tests?

@veer66
Contributor
veer66 commented Jul 6, 2016

Here you are:

ยินดี in Tlwg Typist and Tlwg Typo

tlwg_typist

@kengggg
kengggg commented Jul 6, 2016 edited

Confirm @veer66, the incorrect rendering presents in Servo 0.0.1 on Mac OS X 10.11.5. Following screenshots are captured from Safari 9.1.1 (Left) and Servo 0.0.1 (Right.

screenshot 2016-07-06 15 10 30

Additional information:

The given word ยินดี represents by

0x0E22 0x0E34 0x0E19 0x0E14 0x0E35

But it seems servo has rendered ยินดี as ยินิด that represents by

0x0E22 0x0E34 0x0E19 0x0E34 0x0E14

@bors-servo bors-servo added a commit that referenced this issue Aug 17, 2016
@bors-servo bors-servo Auto merge of #12905 - veer66:master, r=<try>
Fix #12193 Servo displays upper level Thai character in wrong place.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12905)
<!-- Reviewable:end -->
5046ca6
@veer66 veer66 added a commit to veer66/servo that referenced this issue Aug 18, 2016
@veer66 veer66 reftest for issue #12193 Servo displays upper level Thai character in…
… wrong place.
99551ea
@bors-servo bors-servo added a commit that referenced this issue Aug 18, 2016
@bors-servo bors-servo Auto merge of #12905 - veer66:master, r=pcwalton,emilio
Fix #12193 Servo displays upper level Thai character in wrong place.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12905)
<!-- Reviewable:end -->
954ab56
@pcwalton pcwalton added a commit to pcwalton/servo that referenced this issue Sep 26, 2016
@veer66 @pcwalton veer66 + pcwalton reftest for issue #12193 Servo displays upper level Thai character in…
… wrong place.
2ea9a3a
@bors-servo bors-servo added a commit that referenced this issue Sep 26, 2016
@bors-servo bors-servo Auto merge of #13442 - pcwalton:thai, r=<try>
Rebase of #12905: Fix #12193 Servo displays upper level Thai character in wrong place.

Taking over #12905
d8f6841
@veer66 veer66 added a commit to veer66/servo that referenced this issue Sep 29, 2016
@veer66 veer66 reftest for issue #12193 Servo displays upper level Thai character in…
… wrong place.
923fda2
@jdm jdm added a commit to veer66/servo that referenced this issue Feb 1, 2017
@veer66 @jdm veer66 + jdm reftest for issue #12193 Servo displays upper level Thai character in…
… wrong place.
f78ea3a
@jdm jdm added a commit to veer66/servo that referenced this issue Feb 1, 2017
@veer66 @jdm veer66 + jdm reftest for issue #12193 Servo displays upper level Thai character in…
… wrong place.
a83fd07
@bors-servo bors-servo added a commit that referenced this issue Feb 1, 2017
@bors-servo bors-servo Auto merge of #13506 - veer66:master, r=mbrubeck
A test case change is added to #13442: Fix  #12193 Servo displays upper level Thai character in wrong place.

<!-- Please describe your changes on the following line: -->

<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->

---

This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13506)

<!-- Reviewable:end -->
d161f6e
@bors-servo bors-servo closed this in c695674 Feb 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment