Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partial fix for #12415: expose interfaces of some HTML Elements #12617

Merged
merged 1 commit into from Jul 28, 2016
Merged

Partial fix for #12415: expose interfaces of some HTML Elements #12617

merged 1 commit into from Jul 28, 2016

Conversation

mskrzypkows
Copy link

@mskrzypkows mskrzypkows commented Jul 27, 2016 •
edited

Fix for interfaces:
HTMLHeadingElement.webidl
HTMLHRElement.webidl
HTMLHtmlElement.webidl
HTMLHyperlinkElementUtils.webidl
HTMLIFrameElement.webidl
HTMLImageElement.webidl
HTMLInputElement.webidl
HTMLLabelElement.webidl
HTMLLegendElement.webidl
HTMLLIElement.webidl

  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/webidls/HTMLLegendElement.webidl, components/script/dom/webidls/HTMLHtmlElement.webidl, components/script/dom/webidls/HTMLInputElement.webidl, components/script/dom/webidls/HTMLLIElement.webidl, components/script/dom/webidls/HTMLIFrameElement.webidl, components/script/dom/webidls/HTMLImageElement.webidl, components/script/dom/webidls/HTMLHeadingElement.webidl, components/script/dom/webidls/HTMLHyperlinkElementUtils.webidl, components/script/dom/webidls/HTMLHRElement.webidl, components/script/dom/webidls/HTMLLabelElement.webidl

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jul 27, 2016
@Ms2ger
Copy link
Contributor

Ms2ger commented Jul 27, 2016

Excellent, thank you!

@Ms2ger
Copy link
Contributor

Ms2ger commented Jul 27, 2016

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 0eb907b has been approved by Ms2ger

@highfive highfive assigned Ms2ger and unassigned glennw Jul 27, 2016
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jul 27, 2016
@bors-servo
Copy link
Contributor

⌛ Testing commit 0eb907b with merge 28aed40...

bors-servo pushed a commit that referenced this pull request Jul 28, 2016
Auto merge of #12617 - mskrzypkows:expose_interfaces, r=Ms2ger
28aed40 
Partial fix for #12415: expose interfaces of some HTML Elements

<!-- Please describe your changes on the following line: -->
Fix for interfaces:
HTMLHeadingElement.webidl
HTMLHRElement.webidl
HTMLHtmlElement.webidl
HTMLHyperlinkElementUtils.webidl
HTMLIFrameElement.webidl
HTMLImageElement.webidl
HTMLInputElement.webidl
HTMLLabelElement.webidl
HTMLLegendElement.webidl
HTMLLIElement.webidl

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12415

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12617)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Jul 28, 2016
@highfive
Copy link 

  ▶ Unexpected subtest result in /workers/constructors/Worker/unexpected-self-properties.html:
  └ PASS [expected FAIL] unexpected members/interface objects/constructors

@mskrzypkows
Copy link
Author

Should I remove the test? Do my changes really make it pass?

@jdm
Copy link
Member

jdm commented Jul 28, 2016

It's a test that looks at properties of objects in workers, so it seems reasonable, yes.

@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Jul 28, 2016
@mskrzypkows
Copy link
Author

unexpected-self-properties.html removed

@Ms2ger
Copy link
Contributor

Ms2ger commented Jul 28, 2016

Er, you removed the test itself; only the expectation (.ini) file should be removed.

@mskrzypkows
Copy link
Author

OK, I'll bring it back :-)

@jdm jdm added S-needs-code-changes Changes have not yet been made that were requested by a reviewer. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jul 28, 2016
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-code-changes Changes have not yet been made that were requested by a reviewer. labels Jul 28, 2016
@Ms2ger
Copy link
Contributor

Ms2ger commented Jul 28, 2016

Thank you kindly

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 9fa6d50 has been approved by Ms2ger

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jul 28, 2016
bors-servo pushed a commit that referenced this pull request Jul 28, 2016
Auto merge of #12617 - mskrzypkows:expose_interfaces, r=Ms2ger
90243de 
Partial fix for #12415: expose interfaces of some HTML Elements

<!-- Please describe your changes on the following line: -->
Fix for interfaces:
HTMLHeadingElement.webidl
HTMLHRElement.webidl
HTMLHtmlElement.webidl
HTMLHyperlinkElementUtils.webidl
HTMLIFrameElement.webidl
HTMLImageElement.webidl
HTMLInputElement.webidl
HTMLLabelElement.webidl
HTMLLegendElement.webidl
HTMLLIElement.webidl

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12415

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12617)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

⌛ Testing commit 9fa6d50 with merge 90243de...

@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Jul 28, 2016
@jdm
Copy link
Member

jdm commented Jul 28, 2016

@bors-servo: retry

@bors-servo
Copy link
Contributor

⌛ Testing commit 9fa6d50 with merge 82f734b...

bors-servo pushed a commit that referenced this pull request Jul 28, 2016
Auto merge of #12617 - mskrzypkows:expose_interfaces, r=Ms2ger
82f734b 
Partial fix for #12415: expose interfaces of some HTML Elements

<!-- Please describe your changes on the following line: -->
Fix for interfaces:
HTMLHeadingElement.webidl
HTMLHRElement.webidl
HTMLHtmlElement.webidl
HTMLHyperlinkElementUtils.webidl
HTMLIFrameElement.webidl
HTMLImageElement.webidl
HTMLInputElement.webidl
HTMLLabelElement.webidl
HTMLLegendElement.webidl
HTMLLIElement.webidl

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12415

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12617)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Jul 28, 2016
@bors-servo
Copy link
Contributor

☀️ Test successful - arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows-dev

@bors-servo bors-servo merged commit 9fa6d50 into servo:master Jul 28, 2016
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jul 28, 2016
@mskrzypkows mskrzypkows deleted the expose_interfaces branch July 29, 2016 08:31
scotttrinh added a commit to scotttrinh/servo that referenced this pull request Sep 29, 2016
@scotttrinh
Partial fix for servo#12617: expose WebGL interfaces
00ac247
@scotttrinh scotttrinh mentioned this pull request Sep 29, 2016
Merged
5 tasks
bors-servo pushed a commit that referenced this pull request Oct 1, 2016
Auto merge of #13493 - scotttrinh:webgl-idl, r=jdm
5e41bb1 
Partial fix for #12415: expose WebGL interfaces

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes partially fix #12617 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because they do not add any features

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13493)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ms2ger Ms2ger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose interfaces only where they should be.
6 participants
@mskrzypkows @highfive @Ms2ger @bors-servo @jdm @glennw