Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove URL.domainToASCII and URL.domainToUnicode #13835

Closed
nox opened this issue Oct 19, 2016 · 4 comments · Fixed by #13912
Closed

Remove URL.domainToASCII and URL.domainToUnicode #13835

nox opened this issue Oct 19, 2016 · 4 comments · Fixed by #13912
Labels
A-content/dom Interacting with the DOM from web content C-assigned There is someone working on resolving the issue E-less-complex Straightforward. Recommended for a new contributor. I-spec-update

Comments

@nox
Copy link
Contributor

nox commented Oct 19, 2016

They were removed from the spec.

https://twitter.com/urlstandard/status/788712433934270464

Files:

  • components/script/dom/url.rs
  • components/script/dom/webidls/URL.webidl
@nox nox added A-content/dom Interacting with the DOM from web content E-less-complex Straightforward. Recommended for a new contributor. I-spec-update labels Oct 19, 2016
@highfive
Copy link

Please make a comment here if you intend to work on this issue. Thank you!

@Ms2ger
Copy link
Contributor

Ms2ger commented Oct 19, 2016

We should ensure there is a test that these methods are not supported. url/historical.html and url/historical.worker.js are perfect.

@leaexplores
Copy link
Contributor

I'd like to work on this issue.

@Ms2ger Just to make sure I test the good thing. An unsupported method means that both will be undefined right ?

@jdm
Copy link
Member

jdm commented Oct 23, 2016

@ddrmanxbxfr That is correct!

@jdm jdm added the C-assigned There is someone working on resolving the issue label Oct 23, 2016
@leaexplores leaexplores mentioned this issue Oct 24, 2016
Merged
4 tasks
bors-servo pushed a commit that referenced this issue Oct 25, 2016
Auto merge of #13912 - ddrmanxbxfr:remove-deprecated-url-methods, r=M…
0267f28 
…s2ger

Remove URL.domainToASCII and URL.domainToUnicode

Modifications

- Removed URL.domainToASCII method
- Removed URL.domainToUnicode method
- Added test in wpt to make sure both method are undefined.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #13835  (github issue number if applicable).
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13912)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Oct 26, 2016
Auto merge of #13912 - ddrmanxbxfr:remove-deprecated-url-methods, r=M…
4b28750 
…s2ger

Remove URL.domainToASCII and URL.domainToUnicode

Modifications

- Removed URL.domainToASCII method
- Removed URL.domainToUnicode method
- Added test in wpt to make sure both method are undefined.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #13835  (github issue number if applicable).
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13912)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom Interacting with the DOM from web content C-assigned There is someone working on resolving the issue E-less-complex Straightforward. Recommended for a new contributor. I-spec-update
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove URL.domainToASCII and URL.domainToUnicode leaexplores/servo
5 participants
@jdm @Ms2ger @nox @leaexplores @highfive