-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting numeric preferences from the command line #14842
Labels
Comments
Also, it might be useful to make it possible to write automated tests for our command line argument processing code. At minimum the preference-parsing code could be extracted to a helper function and we could add a unit test to |
This came up in the context of #14312 which is using an opt rather than a pref for this reason. |
I'm interested ! Thanks @jdm ! |
charlesvdv
added a commit
to charlesvdv/servo
that referenced
this issue
Jan 5, 2017
Fix for servo#14842. Extract the code inside a function to unit-test it.
4 tasks
charlesvdv
added a commit
to charlesvdv/servo
that referenced
this issue
Jan 5, 2017
Fix for servo#14842. Extract the code inside a function to unit-test it.
charlesvdv
added a commit
to charlesvdv/servo
that referenced
this issue
Jan 5, 2017
Fix for servo#14842. Extract the code inside a function to unit-test it.
bors-servo
pushed a commit
that referenced
this issue
Jan 5, 2017
Allow cli prefs to have numerical value I'm not sure as I'm new with servo but shouldn't the new function ```parse_opt_prefs``` be in ```prefs.rs``` instead of ```opts.rs``` ? <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #14842 <!-- Either: --> - [X] There are tests for these changes OR <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14863) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The code to process
--pref name=value
command line arguments currently recognizes boolean values as special, and otherwise defaults to treating the value as a string. We should check if the value can be parsed as a number and set a numeric preference if possible.Code:
components/config/opts.rs
@charlesvdv Want to fix this?
The text was updated successfully, but these errors were encountered: