Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update style-derive to syn 0.12 #19786

Closed
mystor opened this issue Jan 16, 2018 · 8 comments
Closed

Update style-derive to syn 0.12 #19786

mystor opened this issue Jan 16, 2018 · 8 comments
Labels
I-cleanup No impact; the issue is one of maintainability or tidiness. I-refactor No impact; the issue is one of maintainability or tidiness. Proposed solution requires refactoring.

Comments

@mystor
Copy link
Contributor

mystor commented Jan 16, 2018

Potentially this could allow builds of servo on nightly to get the improved error messages and other semantics which come from the new span system and proc-macro APIs.

synstructure has been updated already, although the API has changed since the last version which style-derive used. If there are any APIs or new features which you need in synstructure to help port the derives over, let me know. Ideally I'd like to make the cg module in style-derive unnecessary, as the features you need are in synstructure.

cc @nox
@jdm jdm added I-refactor No impact; the issue is one of maintainability or tidiness. Proposed solution requires refactoring. I-cleanup No impact; the issue is one of maintainability or tidiness. labels Jan 16, 2018
@upsuper upsuper mentioned this issue Feb 1, 2018
Merged
@upsuper
Copy link
Contributor

upsuper commented Feb 3, 2018 •
edited

So external dependencies which depend on syn are:

@upsuper
Copy link
Contributor

upsuper commented Feb 3, 2018

The hard parts would be html5ever and serde.

@Eijebong
Copy link
Contributor

Eijebong commented Feb 3, 2018

Nah, html5ever is done and serde too

@Eijebong
Copy link
Contributor

Eijebong commented Feb 3, 2018

The hard part for me is style_derive, other servo crates are already done but I couldn't find time/motivation for style_derive...
https://github.com/servo/servo/compare/master...Eijebong:syn?expand=1 here's my work on servo crates

@upsuper
Copy link
Contributor

upsuper commented Feb 3, 2018

Serde's repo is done, but the version published on crates.io hasn't been updated.

@Eijebong
Copy link
Contributor

Eijebong commented Feb 3, 2018 •
edited

Sure, html5ever hasn't even been merged, cssparser hasn't been released either but those are the easy parts, releasing stuff is easy ;)

Edit: the html5ever PR servo/html5ever#336

@upsuper
Copy link
Contributor

upsuper commented Feb 3, 2018

Maybe @nox can help on the style_derive part.

@Eijebong
Copy link
Contributor

Eijebong commented Feb 3, 2018

I just need to find some time to do it but @nox made be buy Celeste so I'm blaming him for the update being late ;)

Eijebong added a commit to Eijebong/servo that referenced this issue Apr 10, 2018
@Eijebong
Dedupe syn, quote and unicode-xid
97cf76b 
Dupe num-traits instead...

Fixes servo#20497
Fixes servo#19786
Closes servo#20564
@Eijebong Eijebong mentioned this issue Apr 10, 2018
Closed
Eijebong added a commit to Eijebong/servo that referenced this issue Apr 10, 2018
@Eijebong
Dedupe syn, quote and unicode-xid
4912bf8 
Dupe num-traits instead...

Fixes servo#20497
Fixes servo#19786
Closes servo#20564
Eijebong added a commit to Eijebong/servo that referenced this issue Apr 10, 2018
@Eijebong
Dedupe syn, quote and unicode-xid
a34af31 
Dupe num-traits instead...

Fixes servo#20497
Fixes servo#19786
Closes servo#20564
Eijebong added a commit to Eijebong/servo that referenced this issue Apr 10, 2018
@Eijebong
Dedupe syn, quote and unicode-xid
84b5dc4 
Dupe num-traits instead...

Fixes servo#20497
Fixes servo#19786
Closes servo#20564
Eijebong added a commit to Eijebong/servo that referenced this issue Apr 10, 2018
@Eijebong
Dedupe syn, quote and unicode-xid
858347b 
Dupe num-traits instead...

Fixes servo#20497
Fixes servo#19786
Closes servo#20564
Eijebong added a commit to Eijebong/servo that referenced this issue Apr 10, 2018
@Eijebong
Dedupe syn, quote and unicode-xid
223ee49 
Dupe num-traits instead...

Fixes servo#20497
Fixes servo#19786
Closes servo#20564
Eijebong added a commit to Eijebong/servo that referenced this issue Apr 10, 2018
@Eijebong
Dedupe syn, quote and unicode-xid
f1b8aca 
Dupe num-traits instead...

Fixes servo#20497
Fixes servo#19786
Closes servo#20564
Eijebong added a commit to Eijebong/servo that referenced this issue Apr 10, 2018
@Eijebong
Dedupe syn, quote and unicode-xid
d3c4228 
Dupe num-traits instead...

Fixes servo#20609
Fixes servo#20497
Fixes servo#19786
Closes servo#20564
bors-servo pushed a commit that referenced this issue Apr 10, 2018
Auto merge of #20611 - Eijebong:(╯°□°）╯︵sǝdnp, r=<try>
da8869c 
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20611)
<!-- Reviewable:end -->
Eijebong added a commit to Eijebong/servo that referenced this issue Apr 10, 2018
@Eijebong
Dedupe syn, quote and unicode-xid
9e21b53 
Dupe num-traits instead...

Fixes servo#20609
Fixes servo#20497
Fixes servo#19786
Closes servo#20564
bors-servo pushed a commit that referenced this issue Apr 10, 2018
Auto merge of #20611 - Eijebong:(╯°□°）╯︵sǝdnp, r=<try>
d5070f6 
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20611)
<!-- Reviewable:end -->
Eijebong added a commit to Eijebong/servo that referenced this issue Apr 10, 2018
@Eijebong
Dedupe syn, quote and unicode-xid
51c3d5a 
Dupe num-traits instead...

Fixes servo#20609
Fixes servo#20497
Fixes servo#19786
Closes servo#20564
bors-servo pushed a commit that referenced this issue Apr 11, 2018
Auto merge of #20611 - Eijebong:(╯°□°）╯︵sǝdnp, r=<try>
a2ebc5f 
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20611)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Apr 17, 2018
Auto merge of #20611 - Eijebong:(╯°□°）╯︵sǝdnp, r=<try>
896c93c 
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20611)
<!-- Reviewable:end -->
Eijebong added a commit to Eijebong/servo that referenced this issue Apr 17, 2018
@Eijebong
Dedupe syn, quote and unicode-xid
16f26fe 
Dupe num-traits instead...

Fixes servo#20609
Fixes servo#20497
Fixes servo#19786
Closes servo#20564
@Eijebong Eijebong mentioned this issue Apr 17, 2018
Merged
bors-servo pushed a commit that referenced this issue Apr 17, 2018
Auto merge of #20649 - Eijebong:taskcluster_ruined_all_the_fun, r=<try>
ea841b1 
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564
bors-servo pushed a commit that referenced this issue Apr 20, 2018
Auto merge of #20649 - Eijebong:taskcluster_ruined_all_the_fun, r=<try>
05aca3d 
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Apr 20, 2018
Auto merge of #20649 - Eijebong:taskcluster_ruined_all_the_fun, r=<try>
06f7fb9 
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Apr 20, 2018
Auto merge of #20649 - Eijebong:taskcluster_ruined_all_the_fun, r=<try>
e8cb8cc 
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)
<!-- Reviewable:end -->
Eijebong added a commit to Eijebong/servo that referenced this issue Apr 20, 2018
@Eijebong
Dedupe syn, quote and unicode-xid
01dc3a2 
Dupe num-traits instead...

Fixes servo#20609
Fixes servo#20497
Fixes servo#19786
Closes servo#20564
bors-servo pushed a commit that referenced this issue Apr 20, 2018
Auto merge of #20649 - Eijebong:taskcluster_ruined_all_the_fun, r=nox
8bd675a 
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Apr 20, 2018
Auto merge of #20649 - Eijebong:taskcluster_ruined_all_the_fun, r=<try>
463b794 
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Apr 20, 2018
Auto merge of #20649 - Eijebong:taskcluster_ruined_all_the_fun, r=<try>
3746cf8 
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Apr 20, 2018
Auto merge of #20649 - Eijebong:taskcluster_ruined_all_the_fun, r=<try>
831d0b8 
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)
<!-- Reviewable:end -->
Eijebong added a commit to Eijebong/servo that referenced this issue Apr 27, 2018
@Eijebong
Dedupe syn, quote, unicode-xid itoa
e67913f 
Fixes servo#20497
Fixes servo#19786
Closes servo#20564
bors-servo pushed a commit that referenced this issue Apr 27, 2018
Auto merge of #20649 - Eijebong:taskcluster_ruined_all_the_fun, r=<try>
c2067a7 
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Apr 27, 2018
Auto merge of #20649 - Eijebong:taskcluster_ruined_all_the_fun, r=<try>
4487326 
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)
<!-- Reviewable:end -->
Eijebong added a commit to Eijebong/servo that referenced this issue Apr 27, 2018
@Eijebong
Dedupe syn, quote, itoa and unicode-xid
e853f2b 
Fixes servo#20497
Fixes servo#19786
Closes servo#20564
Eijebong added a commit to Eijebong/servo that referenced this issue Apr 27, 2018
@Eijebong
Dedupe syn, quote, itoa and unicode-xid
c721069 
Fixes servo#20497
Fixes servo#19786
Closes servo#20564
bors-servo pushed a commit that referenced this issue Apr 27, 2018
Auto merge of #20649 - Eijebong:taskcluster_ruined_all_the_fun, r=<try>
82d521f 
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue May 1, 2018
Auto merge of #20649 - Eijebong:taskcluster_ruined_all_the_fun, r=<try>
e85239d 
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue May 1, 2018
Auto merge of #20649 - Eijebong:taskcluster_ruined_all_the_fun, r=<try>
43124cb 
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue May 1, 2018
Auto merge of #20649 - Eijebong:taskcluster_ruined_all_the_fun, r=<try>
cfa3e25 
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)
<!-- Reviewable:end -->
Eijebong added a commit to Eijebong/servo that referenced this issue May 1, 2018
@Eijebong
Dedupe syn, quote, itoa and unicode-xid
83a6c7f 
Fixes servo#20497
Fixes servo#19786
Closes servo#20564
bors-servo pushed a commit that referenced this issue May 2, 2018
Auto merge of #20649 - Eijebong:taskcluster_ruined_all_the_fun, r=nox
7aaa9c6 
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue May 2, 2018
Auto merge of #20649 - Eijebong:taskcluster_ruined_all_the_fun, r=<try>
e61f5e3 
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue May 2, 2018
Auto merge of #20649 - Eijebong:taskcluster_ruined_all_the_fun, r=<try>
1a5a3b4 
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)
<!-- Reviewable:end -->
Eijebong added a commit to Eijebong/servo that referenced this issue May 2, 2018
@Eijebong
Dedupe syn, quote, itoa and unicode-xid
5fd6fed 
Fixes servo#20497
Fixes servo#19786
Closes servo#20564
bors-servo pushed a commit that referenced this issue May 2, 2018
Auto merge of #20649 - Eijebong:taskcluster_ruined_all_the_fun, r=<try>
340ee57 
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)
<!-- Reviewable:end -->
Eijebong added a commit to Eijebong/servo that referenced this issue May 24, 2018
@Eijebong
Dedupe syn, quote and unicode-xid
e1fe47a 
Fixes servo#20609
Fixes servo#20497
Fixes servo#19786
Closes servo#20564
bors-servo pushed a commit that referenced this issue May 24, 2018
Auto merge of #20649 - Eijebong:taskcluster_ruined_all_the_fun, r=<try>
9d3cb7d 
Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue May 24, 2018
Auto merge of #20649 - Eijebong:taskcluster_ruined_all_the_fun, r=Sim…
62c37e0 
…onSapin

Dedupe syn, quote and unicode-xid

Dupe num-traits instead...

Fixes #20609
Fixes #20497
Fixes #19786
Closes #20564

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20649)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I-cleanup No impact; the issue is one of maintainability or tidiness. I-refactor No impact; the issue is one of maintainability or tidiness. Proposed solution requires refactoring.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jdm @upsuper @mystor @Eijebong