Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Four nondescript WebGL improvements #20598

Merged
merged 4 commits into from
Apr 10, 2018
Merged

Four nondescript WebGL improvements #20598

merged 4 commits into from
Apr 10, 2018

Conversation

nox
Copy link
Contributor

@nox nox commented Apr 9, 2018 •
edited by SimonSapin
Loading

This change is Reviewable

@nox
Fix the error emitted for invalid targets in WebGLTexture::bind
68898f4 
It doesn't actually matter because this is only called from
WebGLRenderingContext::BindTexture, which already checks the target,
but better be safe than sorry.
@highfive
Copy link

highfive commented Apr 9, 2018

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webgltexture.rs, components/script/dom/webgl_validations/tex_image_2d.rs
  • @fitzgen: components/script/dom/webgltexture.rs, components/script/dom/webgl_validations/tex_image_2d.rs
  • @KiChjang: components/script/dom/webgltexture.rs, components/script/dom/webgl_validations/tex_image_2d.rs

@highfive
Copy link

highfive commented Apr 9, 2018

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Apr 9, 2018
@nox
Copy link
Contributor Author

nox commented Apr 9, 2018

@bors-servo try

@bors-servo
Copy link
Contributor

⌛ Trying commit b266597 with merge 642ce84...

bors-servo pushed a commit that referenced this pull request Apr 9, 2018
Auto merge of #20598 - servo:webgl, r=<try>
642ce84 
A pair of nondescript WebGL improvements

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20598)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-dev

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Apr 9, 2018
@highfive highfive removed the S-tests-failed The changes caused existing tests to fail. label Apr 9, 2018
@nox
Copy link
Contributor Author

nox commented Apr 9, 2018

@bors-servo try

@bors-servo
Copy link
Contributor

⌛ Trying commit 561c410 with merge 6718bde...

bors-servo pushed a commit that referenced this pull request Apr 9, 2018
Auto merge of #20598 - servo:webgl, r=<try>
6718bde 
A pair of nondescript WebGL improvements

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20598)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
State: approved= try=True

Manishearth
Manishearth approved these changes Apr 9, 2018
View reviewed changes
Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@emilio emilio mentioned this pull request Apr 10, 2018
Open
@nox nox changed the title A pair of nondescript WebGL improvements Four nondescript WebGL improvements Apr 10, 2018
@nox
Copy link
Contributor Author

nox commented Apr 10, 2018

@bors-servo r=Manishearth

@bors-servo
Copy link
Contributor

📌 Commit f837354 has been approved by Manishearth

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Apr 10, 2018
@bors-servo
Copy link
Contributor

⌛ Testing commit f837354 with merge ce72e52...

bors-servo pushed a commit that referenced this pull request Apr 10, 2018
Auto merge of #20598 - servo:webgl, r=Manishearth
ce72e52 
Four nondescript WebGL improvements

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20598)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-css

@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 10, 2018
@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Apr 10, 2018
@nox
Copy link
Contributor Author

nox commented Apr 10, 2018

@bors-servo retry #18328

@bors-servo
Copy link
Contributor

⚡ Previous build results for android, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-wpt3, windows-msvc-dev are reusable. Rebuilding only arm32, linux-rel-css, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt4...

@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: Manishearth
Pushing ce72e52 to master...

@bors-servo bors-servo merged commit f837354 into master Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth approved these changes

Assignees

@Manishearth Manishearth

Labels
S-tests-failed The changes caused existing tests to fail.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nox @highfive @bors-servo @Manishearth