Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event::bubbles should be initialized to false #2183

Closed
Ms2ger opened this issue Apr 19, 2014 · 3 comments · Fixed by #2233
Closed

Event::bubbles should be initialized to false #2183

Ms2ger opened this issue Apr 19, 2014 · 3 comments · Fixed by #2233
Labels
A-content/dom Interacting with the DOM from web content E-less-complex Straightforward. Recommended for a new contributor. I-wrong An incorrect behaviour is observed.

Comments

@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 19, 2014

http://dom.spec.whatwg.org/#dom-event-bubbles; code in src/components/script/dom/event.rs
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Apr 19, 2014

Blocks #2185.

@MaddieM4
Copy link
Contributor

I'd be happy to do this. I'm just not sure how to test it. Looks like it would be covered in the test suite referenced in #2185, though - is that sufficient?

@jdm
Copy link
Member

jdm commented Apr 21, 2014

Yep! https://github.com/mozilla/servo/wiki/Running-Web-Platform-Tests-on-Servo

MaddieM4 added a commit to MaddieM4/servo that referenced this issue Apr 25, 2014
@MaddieM4
servo#2183 Initialize Event::bubbles to false
6312ff3
@MaddieM4 MaddieM4 mentioned this issue Apr 25, 2014
Merged
bors-servo pushed a commit that referenced this issue Apr 28, 2014
auto merge of #2233 : campadrenalin/servo/initialize-event-bubbling-t…
b6ed246 
…o-false, r=Ms2ger

Fixes #2183.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom Interacting with the DOM from web content E-less-complex Straightforward. Recommended for a new contributor. I-wrong An incorrect behaviour is observed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Initialize Event::bubbles to false MaddieM4/servo
3 participants
@jdm @Ms2ger @MaddieM4