Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intermittent timeout in /html/webappapis/scripting/processing-model-2/unhandled-promise-rejections/promise-rejection-events.html #22207

Closed
jdm opened this issue Nov 16, 2018 · 2 comments · Fixed by #25698
Closed

Intermittent timeout in /html/webappapis/scripting/processing-model-2/unhandled-promise-rejections/promise-rejection-events.html #22207

jdm opened this issue Nov 16, 2018 · 2 comments · Fixed by #25698
Labels
I-intermittent Problem reproduces intermittently.

Comments

@jdm
Copy link
Member

jdm commented Nov 16, 2018 

  ▶ TIMEOUT [expected OK] /html/webappapis/scripting/processing-model-2/unhandled-promise-rejections/promise-rejection-events.html
  │ 
  │ VMware, Inc.
  │ softpipe
  │ 3.3 (Core Profile) Mesa 18.3.0-devel
  │ ERROR 2018-11-15T23:29:23Z: script::dom::bindings::error: Error at http://web-platform.test:8000/resources/testharness.js:3261:1 e is undefined
  │ ERROR 2018-11-15T23:29:23Z: script::dom::bindings::error: Error at http://web-platform.test:8000/resources/testharness.js:3261:1 e is undefined
  └ ERROR 2018-11-15T23:29:23Z: script::dom::bindings::error: Error at http://web-platform.test:8000/resources/testharness.js:3261:1 e is undefined

  ▶ Unexpected subtest result in /html/webappapis/scripting/processing-model-2/unhandled-promise-rejections/promise-rejection-events.html:
  │ TIMEOUT [expected PASS] rejectionhandled is dispatched from a queued task, and not immediately
  └   → Test timed out
@jdm jdm added the I-intermittent Problem reproduces intermittently. label Nov 16, 2018
@jdm jdm mentioned this issue Nov 16, 2018
Merged
@pshaughn
Copy link
Member

pshaughn commented Feb 6, 2020

I can get the "TIMEOUT [expected PASS] rejectionhandled is dispatched from a queued task, and not immediately" every time when I run with a GUI on my notoriously slow VM, so maybe I can get some answers here.

@pshaughn
Copy link
Member

pshaughn commented Feb 6, 2020

This seems to be an accidental performance test! If I change the setTimeout in this test from 10 millis to 100 millis to give everything else a longer chance to happen, then it passes. I'll see if I can find a way to rewrite the test not to depend on clock time.

This was referenced Feb 6, 2020
Closed
Merged
bors-servo pushed a commit that referenced this issue Feb 10, 2020
Auto merge of #25698 - pshaughn:rejectiontests, r=jdm
143b06f 
Fix timeout vs. task-queue race conditions in promise rejection tests

<!-- Please describe your changes on the following line: -->
These two tests were assuming that timeouts and promise rejection events would have a temporal relationship not actually guaranteed by spec, leading to test timeouts if the DOM manipulation task queue was running slower than anticipated.

fix #22207, fix #22295

Of course, the upstream WPT results need looking at to be sure this hasn't done something weird to another browser.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I-intermittent Problem reproduces intermittently.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix timeout vs. task-queue race conditions in promise rejection tests pshaughn/servo
3 participants
@jdm @pshaughn and others