Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUnnecessary cloning in perform_annotated_read_operation #6753
Labels
Comments
|
By closing the issue #6768, i think, this also closed. |
|
Will do this. |
bors-servo
pushed a commit
that referenced
this issue
Aug 6, 2015
Remove Unnecessary Code in FileReader #6753 @jdm r? <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7001) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There's no need for this cloning, since we're just moving the values immediately. I think we can just remove the variables entirely and use
readdata.whateverwhen necessary.Code: components/script/dom/filereader.rs