Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

layout_interface::Msg::Reflow should store ScriptReflow rather than Box<ScriptReflow> #8238

Closed
Ms2ger opened this issue Oct 28, 2015 · 5 comments
Closed

layout_interface::Msg::Reflow should store ScriptReflow rather than Box<ScriptReflow> #8238

Ms2ger opened this issue Oct 28, 2015 · 5 comments
Labels
A-content/script Related to the script thread A-layout/uncategorized C-assigned There is someone working on resolving the issue E-less-complex Straightforward. Recommended for a new contributor. I-perf-bloat Unnecessary memory usage.

Comments

@Ms2ger
Copy link
Contributor

Ms2ger commented Oct 28, 2015

This dates back to 1b03048; there doesn't seem to be an explanation given there.

@pcwalton, any reason not to do this?
@pcwalton
Copy link
Contributor

No reason not to do this.

@Ms2ger Ms2ger added A-layout/uncategorized E-less-complex Straightforward. Recommended for a new contributor. I-perf-bloat Unnecessary memory usage. A-content/script Related to the script thread labels Oct 30, 2015
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Oct 30, 2015

The code is in components/script/layout_interface.rs and components/script/dom/window.rs.

@itsmeolivia
Copy link
Contributor

I can take a look at this!

@eefriedman eefriedman added the C-assigned There is someone working on resolving the issue label Oct 30, 2015
@eefriedman
Copy link
Contributor

If you have any questions, feel free to ask here or on IRC (#servo on irc.mozilla.org).

@itsmeolivia itsmeolivia mentioned this issue Nov 1, 2015
Merged
bors-servo pushed a commit that referenced this issue Nov 1, 2015
Auto merge of #8290 - itsmeolivia:store-script-reflow, r=Ms2ger
601169c 
Un-boxed ScriptReflow

As per #8238 I changed `layout_interface::Msg::Reflow` to store `ScriptReflow` rather than `Box<ScriptReflow>` 

I ran the tests and believe everything passed but this is my first commit to the project so sorry if I messed up the protocol!

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8290)
<!-- Reviewable:end -->
@jdm
Copy link
Member

jdm commented Nov 17, 2015

Fixed by #8290.

@jdm jdm closed this as completed Nov 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/script Related to the script thread A-layout/uncategorized C-assigned There is someone working on resolving the issue E-less-complex Straightforward. Recommended for a new contributor. I-perf-bloat Unnecessary memory usage.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jdm @Ms2ger @pcwalton @itsmeolivia @eefriedman