Remove the msg dependency from style #9261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
highfive
added
the
S-awaiting-review
|
|
|
@bors-servo try |
bors-servo
pushed a commit
that referenced
this pull request
Jan 11, 2016
Remove the msg dependency from style This is part of slimming down the dependencies of geckolib. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9261) <!-- Reviewable:end -->
|
r? @SimonSapin |
| @@ -39,6 +39,7 @@ | |||
| os.path.join(".", "target", "*"), | |||
| os.path.join(".", "ports", "gonk", "src", "native_window_glue.cpp"), | |||
| os.path.join(".", "ports", "cef", "*"), | |||
| os.path.join(".", "ports", "geckolib", "*"), | |||
There was a problem hiding this comment.
I don't think we need to ignore this, do we?
There was a problem hiding this comment.
Good catch - that was an accidental leftover from rebasing this over what actually landed in #9209.
|
☔ The latest upstream changes (presumably #9249) made this pull request unmergeable. Please resolve the merge conflicts. |
|
💔 Test failed - gonk |
|
@bors-servo try |
bholley
force-pushed
the
geckolib_nomsg
branch
from
f99078f
to
e93effe
Compare
|
@bors-servo try |
|
🔒 Merge conflict |
bholley
force-pushed
the
geckolib_nomsg
branch
from
e93effe
to
390d47e
Compare
|
@bors-servo try |
bors-servo
pushed a commit
that referenced
this pull request
Jan 12, 2016
Remove the msg dependency from style This is part of slimming down the dependencies of geckolib. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9261) <!-- Reviewable:end -->
|
💔 Test failed - mac-dev-ref-unit |
|
This is puzzling... #9254 didn't even land yet! |
The pipeline id stuff is currently unused. If someone needs it, they can add an additional trait bound on their css error reporter to get the pipeline id.
bholley
force-pushed
the
geckolib_nomsg
branch
from
390d47e
to
384cdfc
Compare
|
@bors-servo try |
bors-servo
pushed a commit
that referenced
this pull request
Jan 12, 2016
Remove the msg dependency from style This is part of slimming down the dependencies of geckolib. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9261) <!-- Reviewable:end -->
|
☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt |
|
@bors-servo r+ |
|
📌 Commit 384cdfc has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jan 12, 2016
Remove the msg dependency from style This is part of slimming down the dependencies of geckolib. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9261) <!-- Reviewable:end -->
highfive
added
S-awaiting-merge
|
fixes #9246 |
|
☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of slimming down the dependencies of geckolib.