Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special-case setting location.hash to the empty string #11934

Merged
merged 1 commit into from Jun 30, 2016
Merged

Special-case setting location.hash to the empty string #11934

merged 1 commit into from Jun 30, 2016

Conversation

@jdm
Copy link
Member

jdm commented Jun 29, 2016 •
edited by larsbergstrom

This avoids endless redirect loops on facebook and makes us compliant with whatwg/html#1318.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #10952
  • There are tests for these changes OR

This change is Reviewable
@jdm
Ensure that a navigation to the same URL is aborted. Fixes #10952.
Loading status checks…
5cc8de8
@highfive
Copy link

highfive commented Jun 29, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/location.rs
@jdm jdm mentioned this pull request Jun 29, 2016
Closed
4 of 4 tasks complete
@emilio
Copy link
Member

emilio commented Jun 29, 2016

@bors-servo: r+

Finally seeing this going away! :)
@bors-servo
Copy link
Contributor

bors-servo commented Jun 29, 2016

📌 Commit 5cc8de8 has been approved by emilio
@highfive highfive assigned emilio and unassigned Manishearth Jun 29, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Jun 29, 2016

⌛ Testing commit 5cc8de8 with merge e30b288...
bors-servo added a commit that referenced this pull request Jun 29, 2016
@bors-servo
Auto merge of #11934 - jdm:navigatefragment, r=emilio
Loading status checks…
e30b288 
Special-case setting location.hash to the empty string

This avoids endless redirect loops on facebook and makes us compliant with whatwg/html#1318.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #10952
- [X] There are tests for these changes OR

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11934)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 29, 2016

💔 Test failed - linux-rel
@cbrewster
Copy link
Member

cbrewster commented Jun 29, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jun 29, 2016

⚡ Previous build results for android, arm32, arm64, linux-dev, mac-dev-unit, windows are reusable. Rebuilding only linux-rel, mac-rel-css, mac-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 30, 2016

💔 Test failed - linux-rel
@cbrewster
Copy link
Member

cbrewster commented Jun 30, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jun 30, 2016

⚡ Previous build results for android, arm32, arm64, linux-dev, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows are reusable. Rebuilding only linux-rel...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 30, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows
@bors-servo bors-servo merged commit 5cc8de8 into servo:master Jun 30, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Jun 30, 2016
Merged
4 of 4 tasks complete
@cbrewster cbrewster mentioned this pull request Jul 2, 2016
Closed
@utsavoza utsavoza mentioned this pull request Apr 22, 2020
Merged
4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

panicking when loading agar.io
6 participants
@jdm @highfive @emilio @bors-servo @cbrewster @Manishearth
You can’t perform that action at this time.