New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wpt cookie path tests #11624
wpt cookie path tests #11624
Conversation
Fails tidy:
|
Weird, it's passing for me:
How do I reproduce that? |
New code was committed to pull request. |
r? @Ms2ger |
FYI, that's not a tidy check. It's a separate one that runs ./mach update-manifest and verifies the output of git diff. |
☔ The latest upstream changes (presumably #11632) made this pull request unmergeable. Please resolve the merge conflicts. |
c367912
to
96dd595
Compare
☔ The latest upstream changes (presumably #11548) made this pull request unmergeable. Please resolve the merge conflicts. |
96dd595
to
beac1d6
Compare
☔ The latest upstream changes (presumably #11699) made this pull request unmergeable. Please resolve the merge conflicts. |
beac1d6
to
6dfde22
Compare
☔ The latest upstream changes (presumably #11934) made this pull request unmergeable. Please resolve the merge conflicts. |
6dfde22
to
c733bd6
Compare
☔ The latest upstream changes (presumably #12265) made this pull request unmergeable. Please resolve the merge conflicts. |
8817ce4
to
b9e37dc
Compare
b9e37dc
to
4ed7305
Compare
This is looking really great! I'm very interested in that uncaught exception you saw. Reviewed 9 of 21 files at r5. tests/wpt/web-platform-tests/cookies/path/echo-cookie.html, line 13 at r5 (raw file):
The name implies a callback or returning a promise or something. tests/wpt/web-platform-tests/cookies/path/match.html, line 41 at r5 (raw file):
Spooky: https://dxr.mozilla.org/servo/source/components/script/dom/bindings/error.rs?q=failed+to+extract&redirect_type=single#221 . If you have a way to reproduce this, that would be really useful. tests/wpt/web-platform-tests/cookies/path/match.html, line 42 at r5 (raw file):
We'll need to solve the previous problem and remove this setTimeout before we can merge this. tests/wpt/web-platform-tests/cookies/path/match.html, line 50 at r5 (raw file):
nit: spaces instead of tabs. tests/wpt/web-platform-tests/cookies/resources/set-cookie.py, line 24 at r5 (raw file):
Let's remove the print statements in this file. Comments from Reviewable |
4ed7305
to
93b13d0
Compare
Review status: 1 of 4 files reviewed at latest revision, 5 unresolved discussions. tests/wpt/web-platform-tests/cookies/path/echo-cookie.html, line 13 at r5 (raw file):
|
Almost there! A couple last fixups to maximize the ability to report errors effectively and this should be ready to merge! Reviewed 3 of 3 files at r6. tests/wpt/web-platform-tests/cookies/path/match.html, line 41 at r5 (raw file):
|
93b13d0
to
ec68a99
Compare
Review status: 2 of 4 files reviewed at latest revision, 3 unresolved discussions. tests/wpt/web-platform-tests/cookies/path/match.html, line 25 at r6 (raw file):
|
@bors-servo: r+ |
📌 Commit ec68a99 has been approved by |
wpt cookie path tests Adds wpt tests for the cookie path attribute. Notes: * I included polyfills for fetch and promise to get tests running. Assuming these changes are OK, I'll remove them and add failure expectations so they don't get synced to w3c. * I didn't work out a way to test sending cookies when the request and cookie paths exactly match (e.g. request path `/cookies/path/match-exact-page.sub.html` and cookie path `/cookies/path/match-exact-page.sub.html` will not send cookies to `/cookies/resources/echo-json.py`) * test names could be clearer * everything can be squashed to one commit --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #8756 (github issue number if applicable). - [x] These changes do not require tests because they are tests (and if we test our tests do we need to test our test tests? ...) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11624) <!-- Reviewable:end -->
☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev |
Adds wpt tests for the cookie path attribute.
Notes:
/cookies/path/match-exact-page.sub.html
and cookie path/cookies/path/match-exact-page.sub.html
will not send cookies to/cookies/resources/echo-json.py
)./mach build -d
does not report any errors./mach test-tidy
does not report any errorsThis change is