New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OpenEndedDictionary (Mozmap) in the Headers #13356

Merged
merged 1 commit into from Sep 23, 2016

Conversation

Projects
None yet
7 participants
@jeenalee
Contributor

jeenalee commented Sep 21, 2016

This PR will support OpenEndedDictionary (based on MozMap implementation from #13332) in the Headers API.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #11897 (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable

@highfive

This comment has been minimized.

Show comment
Hide comment
@highfive

highfive Sep 21, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/request.rs, components/script/dom/bindings/mozmap.rs, components/script/dom/webidls/Headers.webidl, components/script/dom/headers.rs

highfive commented Sep 21, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/request.rs, components/script/dom/bindings/mozmap.rs, components/script/dom/webidls/Headers.webidl, components/script/dom/headers.rs
@jeenalee

This comment has been minimized.

Show comment
Hide comment
@jeenalee

jeenalee Sep 21, 2016

Contributor

r? @jdm

Contributor

jeenalee commented Sep 21, 2016

r? @jdm

@highfive highfive assigned jdm and unassigned larsbergstrom Sep 21, 2016

@jdm

I'm operating under the assumption that all of the tests now timing out require Promises. These changes look good!

Show outdated Hide outdated components/script/dom/request.rs
Show outdated Hide outdated components/script/dom/request.rs
@jdm

This comment has been minimized.

Show comment
Hide comment
@jdm

jdm Sep 22, 2016

Member

I'm going to hold off merging this until after Promises, since there's a lot of overlap between the test result changes.

Member

jdm commented Sep 22, 2016

I'm going to hold off merging this until after Promises, since there's a lot of overlap between the test result changes.

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 22, 2016

Contributor

☔️ The latest upstream changes (presumably #12830) made this pull request unmergeable. Please resolve the merge conflicts.

Contributor

bors-servo commented Sep 22, 2016

☔️ The latest upstream changes (presumably #12830) made this pull request unmergeable. Please resolve the merge conflicts.

@jdm

This comment has been minimized.

Show comment
Hide comment
@jdm

jdm Sep 22, 2016

Member

If you rebase, I will merge :)

Member

jdm commented Sep 22, 2016

If you rebase, I will merge :)

@jdm

This comment has been minimized.

Show comment
Hide comment
@jdm

jdm Sep 22, 2016

Member

Oh, and go ahead and squash the commits into one.

Member

jdm commented Sep 22, 2016

Oh, and go ahead and squash the commits into one.

@jdm jdm added S-needs-squash and removed S-needs-rebase labels Sep 22, 2016

@jdm

This comment has been minimized.

Show comment
Hide comment
@jdm

jdm Sep 22, 2016

Member

@bors-servo: delegate+

Member

jdm commented Sep 22, 2016

@bors-servo: delegate+

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 22, 2016

Contributor

✌️ @jeenalee can now approve this pull request

Contributor

bors-servo commented Sep 22, 2016

✌️ @jeenalee can now approve this pull request

Enable OpenEndedDictionary in Headers
Expected wpt results are updated as well.
@jeenalee

This comment has been minimized.

Show comment
Hide comment
@jeenalee

jeenalee Sep 22, 2016

Contributor

@bors-servo: r=jdm

Contributor

jeenalee commented Sep 22, 2016

@bors-servo: r=jdm

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 22, 2016

Contributor

📌 Commit 3b75d22 has been approved by jdm

Contributor

bors-servo commented Sep 22, 2016

📌 Commit 3b75d22 has been approved by jdm

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 22, 2016

Contributor

⌛️ Testing commit 3b75d22 with merge 68e7ff3...

Contributor

bors-servo commented Sep 22, 2016

⌛️ Testing commit 3b75d22 with merge 68e7ff3...

bors-servo added a commit that referenced this pull request Sep 22, 2016

Auto merge of #13356 - jeenalee:mozmap-headers, r=jdm
Support OpenEndedDictionary (Mozmap) in the Headers

<!-- Please describe your changes on the following line: -->

This PR will support OpenEndedDictionary (based on MozMap implementation from #13332) in the Headers API.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #11897  (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13356)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 23, 2016

Contributor

💔 Test failed - linux-rel

Contributor

bors-servo commented Sep 23, 2016

💔 Test failed - linux-rel

@highfive

This comment has been minimized.

Show comment
Hide comment
@highfive

highfive Sep 23, 2016

  ▶ Unexpected subtest result in /_mozilla/mozilla/promise.html:
  │ FAIL [expected PASS] Native promise from async callback can be resolved
  │   → assert_true: expected true got false
  │ 
  └ @http://web-platform.test:8000/_mozilla/mozilla/promise.html:58:11

highfive commented Sep 23, 2016

  ▶ Unexpected subtest result in /_mozilla/mozilla/promise.html:
  │ FAIL [expected PASS] Native promise from async callback can be resolved
  │   → assert_true: expected true got false
  │ 
  └ @http://web-platform.test:8000/_mozilla/mozilla/promise.html:58:11
@Ms2ger

This comment has been minimized.

Show comment
Hide comment
@Ms2ger
Contributor

Ms2ger commented Sep 23, 2016

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 23, 2016

Contributor

⌛️ Testing commit 3b75d22 with merge 0ecaa77...

Contributor

bors-servo commented Sep 23, 2016

⌛️ Testing commit 3b75d22 with merge 0ecaa77...

bors-servo added a commit that referenced this pull request Sep 23, 2016

Auto merge of #13356 - jeenalee:mozmap-headers, r=jdm
Support OpenEndedDictionary (Mozmap) in the Headers

<!-- Please describe your changes on the following line: -->

This PR will support OpenEndedDictionary (based on MozMap implementation from #13332) in the Headers API.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #11897  (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13356)
<!-- Reviewable:end -->

bors-servo added a commit that referenced this pull request Sep 23, 2016

Auto merge of #13356 - jeenalee:mozmap-headers, r=jdm
Support OpenEndedDictionary (Mozmap) in the Headers

<!-- Please describe your changes on the following line: -->

This PR will support OpenEndedDictionary (based on MozMap implementation from #13332) in the Headers API.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #11897  (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13356)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Sep 23, 2016

Contributor

⌛️ Testing commit 3b75d22 with merge 06f7a64...

Contributor

bors-servo commented Sep 23, 2016

⌛️ Testing commit 3b75d22 with merge 06f7a64...

@bors-servo bors-servo referenced this pull request Sep 23, 2016

Merged

Flush style sharing cache on parent mismatch. #13312

4 of 5 tasks complete
@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo
Contributor

bors-servo commented Sep 23, 2016

@bors-servo bors-servo merged commit 3b75d22 into servo:master Sep 23, 2016

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment