-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stylo: Implement shape-outside property #16384
Conversation
Heads up! This PR modifies the following files:
|
r? @Manishearth |
@bors-servo r=Manishearth |
📌 Commit d0619a7 has been approved by |
@bors-servo p=1 needs coordinated landing |
⌛ Testing commit d0619a7 with merge c154683a9962902ddfebffad5f1b25e9d21f139e... |
⛄ The build was interrupted to prioritize another pull request. |
@bors-servo r- will try coordinated landing tomorrow. hopefully servo queue will have cleared up by then |
@bors-servo r+ |
📌 Commit d0619a7 has been approved by |
stylo: Implement shape-outside property shape-outside property implemented. r=Manishearth in bugzilla --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #15958 and [Bug 1355003](https://bugzilla.mozilla.org/show_bug.cgi?id=1355003) <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16384) <!-- Reviewable:end -->
💔 Test failed - android |
@bors-servo retry weird android failure
|
⚡ Previous build results for arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev are reusable. Rebuilding only android... |
💔 Test failed - android |
@bors-servo are you still there? |
@bors-servo r+ |
💡 This pull request was already approved, no need to approve it again.
|
📌 Commit d0619a7 has been approved by |
⚡ Previous build results for arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev are reusable. Rebuilding only android... |
💔 Test failed - android |
@bors-servo r+ |
💡 This pull request was already approved, no need to approve it again.
|
📌 Commit d0619a7 has been approved by |
⚡ Previous build results for arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev are reusable. Rebuilding only android... |
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev |
MozReview-Commit-ID: AzvlNohO10v
MozReview-Commit-ID: AzvlNohO10v
shape-outside property implemented.
r=Manishearth in bugzilla
./mach build -d
does not report any errors./mach test-tidy
does not report any errorsThis change is