Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Replace intrinsics::abort with process::abort" #16899

Merged
merged 2 commits into from May 17, 2017
Merged

Revert "Replace intrinsics::abort with process::abort" #16899

merged 2 commits into from May 17, 2017

Conversation

jdm
Copy link
Member

@jdm jdm commented May 16, 2017 •
edited by larsbergstrom

This reverts #16680. Calling process::abort from the crash handler causes the crash handler to be invoked again recursively.

This change is Reviewable

@highfive
Copy link

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label May 16, 2017
emilio
emilio approved these changes May 16, 2017
View reviewed changes
Copy link
Member

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with a comment on that.

@SimonSapin SimonSapin mentioned this pull request May 16, 2017
Closed
@jdm
Copy link
Member Author

jdm commented May 16, 2017

@bors-servo: r=emilio p=1

@bors-servo
Copy link
Contributor

📌 Commit 3fef253 has been approved by emilio

@highfive highfive assigned emilio and unassigned glennw May 16, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels May 16, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit 3fef253 with merge 1312ab2...

bors-servo pushed a commit that referenced this pull request May 16, 2017
Auto merge of #16899 - jdm:revertabort, r=emilio
1312ab2 
Revert "Replace intrinsics::abort with process::abort"

This reverts #16680. Calling `process::abort` from the crash handler causes the crash handler to be invoked again recursively.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #16898

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16899)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: emilio
Pushing 1312ab2 to master...

@bors-servo bors-servo merged commit 3fef253 into servo:master May 17, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label May 17, 2017
@SimonSapin SimonSapin mentioned this pull request Jun 5, 2017
Closed
@SimonSapin SimonSapin mentioned this pull request Jul 2, 2018
Open
2 tasks
@SimonSapin SimonSapin mentioned this pull request May 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio emilio approved these changes

Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Calling process::abort from crash handler re-triggers crash handler
5 participants
@jdm @highfive @bors-servo @emilio @glennw