Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling process::abort from crash handler re-triggers crash handler #16898

Closed
jdm opened this issue May 16, 2017 · 0 comments · Fixed by #16899
Closed

Calling process::abort from crash handler re-triggers crash handler #16898

jdm opened this issue May 16, 2017 · 0 comments · Fixed by #16899

Comments

@jdm
Copy link
Member

jdm commented May 16, 2017

From a recent builder log:

  │ Stack trace for thread "ScriptThread PipelineId { namespace_id: PipelineNamespaceId(0), index: PipelineIndex(1) }"
  │ stack backtrace:
  │    0:     0x7f0a935815cc - backtrace::backtrace::trace::haa53f4880ff627c6
  │    1:     0x7f0a93581a92 - backtrace::capture::Backtrace::new::h5f3de869c0349b3d
  │    2:     0x7f0a921545cd - servo::install_crash_handler::handler::h47b241f6e5ce7481
  │    3:     0x7f0a932fddf3 - AsmJSFaultHandler
  │                         at /home/servo/.cargo/git/checkouts/mozjs-fa11ffc7d4f1cc2d/834ce35/mozjs/js/src/asmjs/WasmSignalHandlers.cpp:1171
  │    4:     0x7f0a9007832f - <unknown>
  │    5:     0x7f0a931f8bdd - _Z14mozalloc_abortPKc
  │                         at /home/servo/.cargo/git/checkouts/mozjs-fa11ffc7d4f1cc2d/834ce35/mozjs/memory/mozalloc/mozalloc_abort.cpp:33
  │    6:     0x7f0a931f8bbf - abort
  │                         at /home/servo/.cargo/git/checkouts/mozjs-fa11ffc7d4f1cc2d/834ce35/mozjs/memory/mozalloc/mozalloc_abort.cpp:80
  │    7:     0x7f0a94177d88 - std::sys::imp::abort_internal
  │                         at /checkout/src/libstd/sys/unix/mod.rs:175
  │                          - std::process::abort
  │                         at /checkout/src/libstd/process.rs:1097
  │    8:     0x7f0a92154724 - servo::install_crash_handler::handler::h47b241f6e5ce7481
  │    9:     0x7f0a932fddf3 - AsmJSFaultHandler
  │                         at /home/servo/.cargo/git/checkouts/mozjs-fa11ffc7d4f1cc2d/834ce35/mozjs/js/src/asmjs/WasmSignalHandlers.cpp:1171
  │   10:     0x7f0a9007832f - <unknown>
  │   11:     0x7f0a931f8bdd - _Z14mozalloc_abortPKc
  │                         at /home/servo/.cargo/git/checkouts/mozjs-fa11ffc7d4f1cc2d/834ce35/mozjs/memory/mozalloc/mozalloc_abort.cpp:33
  │   12:     0x7f0a931f8bbf - abort
  │                         at /home/servo/.cargo/git/checkouts/mozjs-fa11ffc7d4f1cc2d/834ce35/mozjs/memory/mozalloc/mozalloc_abort.cpp:80
  │   13:     0x7f0a94177d88 - std::sys::imp::abort_internal
  │                         at /checkout/src/libstd/sys/unix/mod.rs:175
  │                          - std::process::abort
  │                         at /checkout/src/libstd/process.rs:1097
  │   14:     0x7f0a92154724 - servo::install_crash_handler::handler::h47b241f6e5ce7481
  │   15:     0x7f0a932fddf3 - AsmJSFaultHandler
  │                         at /home/servo/.cargo/git/checkouts/mozjs-fa11ffc7d4f1cc2d/834ce35/mozjs/js/src/asmjs/WasmSignalHandlers.cpp:1171
  │   16:     0x7f0a9007832f - <unknown>
  │   17:     0x7f0a931f8bdd - _Z14mozalloc_abortPKc
  │                         at /home/servo/.cargo/git/checkouts/mozjs-fa11ffc7d4f1cc2d/834ce35/mozjs/memory/mozalloc/mozalloc_abort.cpp:33
  │   18:     0x7f0a931f8bbf - abort
  │                         at /home/servo/.cargo/git/checkouts/mozjs-fa11ffc7d4f1cc2d/834ce35/mozjs/memory/mozalloc/mozalloc_abort.cpp:80
  │   19:     0x7f0a94177d88 - std::sys::imp::abort_internal
  │                         at /checkout/src/libstd/sys/unix/mod.rs:175
  │                          - std::process::abort
  │                         at /checkout/src/libstd/process.rs:1097
  │   20:     0x7f0a92154724 - servo::install_crash_handler::handler::h47b241f6e5ce7481
  │   21:     0x7f0a932fddf3 - AsmJSFaultHandler
  │                         at /home/servo/.cargo/git/checkouts/mozjs-fa11ffc7d4f1cc2d/834ce35/mozjs/js/src/asmjs/WasmSignalHandlers.cpp:1171
  │   22:     0x7f0a9007832f - <unknown>
  │   23:     0x7f0a931f8bdd - _Z14mozalloc_abortPKc
  │                         at /home/servo/.cargo/git/checkouts/mozjs-fa11ffc7d4f1cc2d/834ce35/mozjs/memory/mozalloc/mozalloc_abort.cpp:33
  │   24:     0x7f0a931f8bbf - abort
  │                         at /home/servo/.cargo/git/checkouts/mozjs-fa11ffc7d4f1cc2d/834ce35/mozjs/memory/mozalloc/mozalloc_abort.cpp:80
  │   25:     0x7f0a94177d88 - std::sys::imp::abort_internal
  │                         at /checkout/src/libstd/sys/unix/mod.rs:175
  │                          - std::process::abort
  │                         at /checkout/src/libstd/process.rs:1097
  │   26:     0x7f0a92154724 - servo::install_crash_handler::handler::h47b241f6e5ce7481
...
This was referenced May 16, 2017
Merged
Merged
bors-servo pushed a commit that referenced this issue May 16, 2017
Auto merge of #16899 - jdm:revertabort, r=emilio
1312ab2 
Revert "Replace intrinsics::abort with process::abort"

This reverts #16680. Calling `process::abort` from the crash handler causes the crash handler to be invoked again recursively.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #16898

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16899)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "Replace intrinsics::abort with process::abort" jdm/servo
1 participant
@jdm