Update concept of node filter algorithm #18255

CYBAI · 2017-08-26T18:45:54Z

Implement new filter algorithm from specification

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix Prevent reentrancy in TreeWalker::accept_node and NodeIterator::accept_node #18218 (github issue number if applicable).
These changes do not require tests because changes are minimal and the error was triggered by a test

This change is

highfive · 2017-08-26T18:46:02Z

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @glennw (or someone else) soon.

highfive · 2017-08-26T18:46:03Z

Heads up! This PR modifies the following files:

@fitzgen: components/script/dom/nodeiterator.rs, components/script/dom/treewalker.rs
@KiChjang: components/script/dom/nodeiterator.rs, components/script/dom/treewalker.rs

highfive · 2017-08-26T18:46:04Z

Warning

These commits modify script code, but no tests are modified. Please consider adding a test!

KiChjang · 2017-08-26T23:18:07Z

components/script/dom/treewalker.rs

+        //     "acceptNode", and a list of arguments consisting of node. If that throws an exception,
+        //     then unset the active flag and rethrow the exception."
+        // "7. Unset the active flag"
+        // "8. Return result."


I'm not sure why these step annotations are there, we usually just do step n. @nox?

@KiChjang Due to the existing step annotation, I just updated them to the new one. If they're unnecessary, please let me remove them.

These seem to be left by a contributor back in #3253, when we did not have guidelines as to how we're supposed to leave step annotations.
So yes, please change them back into step n instead.

jdm · 2017-08-27T07:04:15Z

@bors-servo: try

bors-servo · 2017-08-27T07:04:20Z

⌛ Trying commit 777d098 with merge 80a839b...

Update concept of node filter algorithm Implement new [filter](https://dom.spec.whatwg.org/#concept-node-filter) algorithm from specification --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #18218 (github issue number if applicable). - [ ] There are tests for these changes OR - [X] These changes do not require tests because changes are minimal and the error was triggered by a test  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18255)

bors-servo · 2017-08-27T07:04:36Z

💔 Test failed - mac-rel-wpt2

CYBAI · 2017-08-27T09:59:13Z

@jdm @KiChjang @shinglyu
Is this build error from @bors-servo related to #18228 ?

KiChjang · 2017-08-27T10:01:09Z

Yeah, looks like it.

bors-servo · 2017-08-29T01:23:49Z

⌛ Trying commit 777d098 with merge 57365363463332696f457fac71184afa83fadafe...

bors-servo · 2017-08-29T01:23:55Z

⌛ Trying commit 777d098 with merge be11311...

Update concept of node filter algorithm Implement new [filter](https://dom.spec.whatwg.org/#concept-node-filter) algorithm from specification --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #18218 (github issue number if applicable). - [X] These changes do not require tests because changes are minimal and the error was triggered by a test  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18255)

shinglyu · 2017-08-29T01:24:52Z

Sorry for triggering it two times. I though I had the wrong syntax so asked twice.

bors-servo · 2017-08-29T02:59:58Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
State: approved= try=True

jdm · 2017-08-29T14:47:25Z

I bet there are tests upstream that would be affected by this, but we're currently stuck on an old version of web-platform-tests :(

CYBAI · 2017-08-29T15:02:39Z

Hi @jdm , is there anything I can help or update for it?

shinglyu · 2017-08-31T03:56:30Z

#17416 <= this?

CYBAI · 2017-09-23T16:11:18Z

ping @shinglyu @jdm @KiChjang
Is there anything I can help or update for this PR?

bors-servo · 2017-09-26T09:30:17Z

☔ The latest upstream changes (presumably #18635) made this pull request unmergeable. Please resolve the merge conflicts.

bors-servo · 2017-10-19T04:54:30Z

☔ The latest upstream changes (presumably #18921) made this pull request unmergeable. Please resolve the merge conflicts.

CYBAI · 2017-10-21T16:05:59Z

@bors-servo: try

bors-servo · 2017-10-21T16:06:00Z

@CYBAI: 🔑 Insufficient privileges: and not in try users

wafflespeanut · 2017-10-21T16:07:11Z

@bors-servo try

bors-servo · 2017-10-21T16:07:15Z

⌛ Trying commit 8245aad with merge 6be2082...

Update concept of node filter algorithm Implement new [filter](https://dom.spec.whatwg.org/#concept-node-filter) algorithm from specification --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #18218 (github issue number if applicable). - [X] These changes do not require tests because changes are minimal and the error was triggered by a test  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18255)

CYBAI · 2017-10-21T16:07:56Z

@wafflespeanut Thanks!

bors-servo · 2017-10-21T19:39:49Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
State: approved= try=True

jdm · 2017-10-21T20:13:01Z

@bors-servo: r+

bors-servo · 2017-10-21T20:13:01Z

📌 Commit 8245aad has been approved by jdm

bors-servo · 2017-10-21T20:13:06Z

⌛ Testing commit 8245aad with merge 1667fcc...

Update concept of node filter algorithm Implement new [filter](https://dom.spec.whatwg.org/#concept-node-filter) algorithm from specification --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #18218 (github issue number if applicable). - [X] These changes do not require tests because changes are minimal and the error was triggered by a test  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18255)

KiChjang · 2017-10-21T20:19:15Z

@CYBAI Your 2nd commit message is incorrect, you're not removing legacy tests - you're updating test expectations.

But instead of renaming it, can I ask you to squash your commits into one, please?

bors-servo · 2017-10-21T22:09:36Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing 1667fcc to master...

CYBAI · 2017-10-22T06:50:30Z

@KiChjang Oh... sorry for late reply. This PR has been merged. How can I update them or any way I can help? Thank.

highfive assigned glennw Aug 26, 2017

highfive added the S-awaiting-review There is new code that needs to be reviewed. label Aug 26, 2017

KiChjang reviewed Aug 26, 2017

View reviewed changes

CYBAI force-pushed the prevent-reentrancy-pr18218 branch from 049c2c1 to 777d098 Compare August 27, 2017 05:25

highfive added the S-tests-failed The changes caused existing tests to fail. label Aug 27, 2017

CYBAI force-pushed the prevent-reentrancy-pr18218 branch from 777d098 to 5339123 Compare September 17, 2017 01:12

highfive removed the S-tests-failed The changes caused existing tests to fail. label Sep 17, 2017

highfive added the S-needs-rebase There are merge conflict errors. label Sep 26, 2017

CYBAI force-pushed the prevent-reentrancy-pr18218 branch 2 times, most recently from f325650 to f846d87 Compare September 30, 2017 14:07

jdm removed the S-tests-failed The changes caused existing tests to fail. label Oct 18, 2017

highfive added the S-needs-rebase There are merge conflict errors. label Oct 19, 2017

CYBAI added 2 commits October 19, 2017 22:01

Update concept of node filter algorithm

cb8b52c

Remove legacy tests

8245aad

CYBAI force-pushed the prevent-reentrancy-pr18218 branch from 3f7139b to 8245aad Compare October 19, 2017 14:04

highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-code-changes Changes have not yet been made that were requested by a reviewer. labels Oct 19, 2017

highfive assigned jdm and unassigned nox Oct 21, 2017

highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. S-needs-rebase There are merge conflict errors. labels Oct 21, 2017

bors-servo merged commit 8245aad into servo:master Oct 21, 2017

highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Oct 21, 2017

CYBAI deleted the prevent-reentrancy-pr18218 branch October 23, 2017 16:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update concept of node filter algorithm #18255

Update concept of node filter algorithm #18255

CYBAI commented Aug 26, 2017 •

edited

highfive commented Aug 26, 2017

highfive commented Aug 26, 2017

highfive commented Aug 26, 2017

KiChjang Aug 26, 2017 •

edited

CYBAI Aug 27, 2017

KiChjang Aug 27, 2017

jdm commented Aug 27, 2017

bors-servo commented Aug 27, 2017

bors-servo commented Aug 27, 2017

CYBAI commented Aug 27, 2017

KiChjang commented Aug 27, 2017

bors-servo commented Aug 29, 2017

bors-servo commented Aug 29, 2017

shinglyu commented Aug 29, 2017

bors-servo commented Aug 29, 2017

jdm commented Aug 29, 2017

CYBAI commented Aug 29, 2017

shinglyu commented Aug 31, 2017

CYBAI commented Sep 23, 2017

bors-servo commented Sep 26, 2017

bors-servo commented Oct 19, 2017

CYBAI commented Oct 21, 2017

bors-servo commented Oct 21, 2017

wafflespeanut commented Oct 21, 2017

bors-servo commented Oct 21, 2017

CYBAI commented Oct 21, 2017

bors-servo commented Oct 21, 2017

jdm commented Oct 21, 2017

bors-servo commented Oct 21, 2017

bors-servo commented Oct 21, 2017

KiChjang commented Oct 21, 2017

bors-servo commented Oct 21, 2017

CYBAI commented Oct 22, 2017

Update concept of node filter algorithm #18255

Update concept of node filter algorithm #18255

Conversation

CYBAI commented Aug 26, 2017 • edited

highfive commented Aug 26, 2017

highfive commented Aug 26, 2017

highfive commented Aug 26, 2017

KiChjang Aug 26, 2017 • edited

Choose a reason for hiding this comment

CYBAI Aug 27, 2017

Choose a reason for hiding this comment

KiChjang Aug 27, 2017

Choose a reason for hiding this comment

jdm commented Aug 27, 2017

bors-servo commented Aug 27, 2017

bors-servo commented Aug 27, 2017

CYBAI commented Aug 27, 2017

KiChjang commented Aug 27, 2017

bors-servo commented Aug 29, 2017

bors-servo commented Aug 29, 2017

shinglyu commented Aug 29, 2017

bors-servo commented Aug 29, 2017

jdm commented Aug 29, 2017

CYBAI commented Aug 29, 2017

shinglyu commented Aug 31, 2017

CYBAI commented Sep 23, 2017

bors-servo commented Sep 26, 2017

bors-servo commented Oct 19, 2017

CYBAI commented Oct 21, 2017

bors-servo commented Oct 21, 2017

wafflespeanut commented Oct 21, 2017

bors-servo commented Oct 21, 2017

CYBAI commented Oct 21, 2017

bors-servo commented Oct 21, 2017

jdm commented Oct 21, 2017

bors-servo commented Oct 21, 2017

bors-servo commented Oct 21, 2017

KiChjang commented Oct 21, 2017

bors-servo commented Oct 21, 2017

CYBAI commented Oct 22, 2017

CYBAI commented Aug 26, 2017 •

edited

KiChjang Aug 26, 2017 •

edited