New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw a TypeError when too few arguments are passed. #2194
Conversation
Critic review: https://critic.hoppipolla.co.uk/r/1331 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
I'm guessing this can't be merged until the rustc upgrade goes through, since the rust-mozjs change comes after the rust upgrade commits. |
I think it can, actually; servo/rust-mozjs@7dd29a0 doesn't include the upgrade commits (while the merge commit servo/rust-mozjs@00b3b1e does). |
@jdm: I'm pretty sure it can now |
Please to address Critic comments. |
The first 11 tests in Event-constructors.html were fixed in servo#2194; the remaining failure is servo#2173. Node-normalize.html was fixed in servo#2221.
No description provided.