Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw a TypeError when too few arguments are passed. #2194

Merged
merged 3 commits into from Apr 28, 2014
Merged

Throw a TypeError when too few arguments are passed. #2194

merged 3 commits into from Apr 28, 2014

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Apr 20, 2014

No description provided.

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Apr 20, 2014

Critic review: https://critic.hoppipolla.co.uk/r/1331

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@highfive
Copy link

highfive commented Apr 20, 2014

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@jdm
Copy link
Member

jdm commented Apr 20, 2014

I'm guessing this can't be merged until the rustc upgrade goes through, since the rust-mozjs change comes after the rust upgrade commits.
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Apr 20, 2014

I think it can, actually; servo/rust-mozjs@7dd29a0 doesn't include the upgrade commits (while the merge commit servo/rust-mozjs@00b3b1e does).
@jdm jdm mentioned this pull request Apr 21, 2014
Closed
@Ms2ger
Throw a TypeError when too few arguments are passed.
bfde816
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Apr 28, 2014

@jdm: I'm pretty sure it can now
@jdm
Copy link
Member

jdm commented Apr 28, 2014

Please to address Critic comments.
Ms2ger added 2 commits Apr 28, 2014
@Ms2ger
Move ThrowTypeError to error.rs.
7ff9fff
@Ms2ger
Use more rustic names for ThrowTypeError and infrastructure.
Loading status checks…
505e7d4
@jdm

This comment has been minimized.

Sign in to view
Copy link

jdm commented on 505e7d4 Apr 28, 2014

r+
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented on 505e7d4 Apr 28, 2014

saw approval from jdm
at Ms2ger@505e7d4

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Apr 28, 2014

merging Ms2ger/servo/typeerror-2 = 505e7d4 into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Apr 28, 2014

Ms2ger/servo/typeerror-2 = 505e7d4 merged ok, testing candidate = 0bfbe06

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Apr 28, 2014

all tests pass:
success: http://servo-buildbot.pub.build.mozilla.org/builders/linux/builds/1296
success: http://servo-buildbot.pub.build.mozilla.org/builders/mac/builds/1250

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Apr 28, 2014

fast-forwarding master to auto = 0bfbe06
bors-servo pushed a commit that referenced this pull request Apr 28, 2014
bors-servo
auto merge of #2194 : Ms2ger/servo/typeerror-2, r=jdm
0bfbe06
@bors-servo bors-servo merged commit 505e7d4 into servo:master Apr 28, 2014
1 check passed
1 check passed
default all tests passed
Ms2ger added a commit to Ms2ger/servo that referenced this pull request May 2, 2014
@Ms2ger
Update web-platform-tests expectations.
0a47659 
The first 11 tests in Event-constructors.html were fixed in servo#2194; the
remaining failure is servo#2173. Node-normalize.html was fixed in servo#2221.
@Ms2ger Ms2ger mentioned this pull request May 2, 2014
Merged
bors-servo pushed a commit that referenced this pull request May 2, 2014
bors-servo
auto merge of #2294 : Ms2ger/servo/update-wpt, r=jdm
9b6b552 
The first 11 tests in Event-constructors.html were fixed in #2194; the
remaining failure is #2173. Node-normalize.html was fixed in #2221.
@Ms2ger Ms2ger deleted the Ms2ger:typeerror-2 branch May 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Ms2ger @hoppipolla-critic-bot @highfive @jdm @bors-servo
You can’t perform that action at this time.