Kill off hanging crashtests. #25670
Merged
Kill off hanging crashtests. #25670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Opened new PR for upstreamable changes. Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#21537. |
|
@bors-servo p=3 r+ |
|
📌 Commit 44a2953 has been approved by |
highfive
added
S-awaiting-merge
This was referenced Feb 1, 2020
bors-servo
pushed a commit
that referenced
this pull request
Feb 1, 2020
Kill off hanging crashtests. The reason that complex-glsl-does-not-crash.html kept leaving zombie processes is the following: * WPT introduced the notion of crash tests (ie. tests that verify that they do not crash) * if a timeout expires while running a crash test and the test has not finished running, it is reported as a failure and potential hang * there is no code that causes a hanging test to stop running * any test filename that ends in `-crash` is automatically treated as a crashtest
|
💔 Test failed - status-taskcluster |
highfive
added
S-tests-failed
bors-servo
pushed a commit
that referenced
this pull request
Feb 1, 2020
Kill off hanging crashtests. The reason that complex-glsl-does-not-crash.html kept leaving zombie processes is the following: * WPT introduced the notion of crash tests (ie. tests that verify that they do not crash) * if a timeout expires while running a crash test and the test has not finished running, it is reported as a failure and potential hang * there is no code that causes a hanging test to stop running * any test filename that ends in `-crash` is automatically treated as a crashtest
highfive
added
S-awaiting-merge
|
💔 Test failed - status-taskcluster |
highfive
added
S-tests-failed
bors-servo
pushed a commit
that referenced
this pull request
Feb 1, 2020
Kill off hanging crashtests. The reason that complex-glsl-does-not-crash.html kept leaving zombie processes is the following: * WPT introduced the notion of crash tests (ie. tests that verify that they do not crash) * if a timeout expires while running a crash test and the test has not finished running, it is reported as a failure and potential hang * there is no code that causes a hanging test to stop running * any test filename that ends in `-crash` is automatically treated as a crashtest
highfive
added
the
S-awaiting-merge
|
☀️ Test successful - status-taskcluster |
highfive
removed
the
S-awaiting-merge
|
Error syncing changes upstream. Logs saved in error-snapshot-1580533360933. |
|
@jdm not sure what error it is; I saw the |
|
#25796 (comment) reminds me to check this one and it's not merged yet 👀 cc @jdm |
|
Thanks for the reminder! I manually merged it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason that complex-glsl-does-not-crash.html kept leaving zombie processes is the following:
-crashis automatically treated as a crashtest