Make Layout 2013 style a superset of Layout 2020 style #29940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors-servo try=wpt |
bors-servo
added a commit
that referenced
this pull request
Jun 27, 2023
Make Layout 2013 style a superset of Layout 2020 style This is the first step toward removing the compile-time difference in style between Layout 2020 and Layout 2013. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
mrobinson
force-pushed
the
servo-2013-superset
branch
from
6b3eec7
to
ce35566
Compare
|
Test results for linux-wpt-layout-2013 from try job (#5393974929): Flaky unexpected result (16)
Stable unexpected results that are known to be intermittent (9)
Stable unexpected results (26)
|
mrobinson
force-pushed
the
servo-2013-superset
branch
from
ce35566
to
bb4335d
Compare
|
@bors-servo try=wpt |
bors-servo
added a commit
that referenced
this pull request
Jun 28, 2023
Make Layout 2013 style a superset of Layout 2020 style This is the first step toward removing the compile-time difference in style between Layout 2020 and Layout 2013. This change: - Adds `attr()` CSS content support to legacy layout - Adds parsing support for some unsupported features such as `display: flow-root` and `display: contents`. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
💔 Test failed - checks-github |
mrobinson
force-pushed
the
servo-2013-superset
branch
from
bb4335d
to
afc8c51
Compare
|
@bors-servo try=wpt |
bors-servo
added a commit
that referenced
this pull request
Jun 28, 2023
Make Layout 2013 style a superset of Layout 2020 style This is the first step toward removing the compile-time difference in style between Layout 2020 and Layout 2013. This change: - Adds `attr()` CSS content support to legacy layout - Adds parsing support for some unsupported features such as `display: flow-root` and `display: contents`. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
mrobinson
force-pushed
the
servo-2013-superset
branch
from
afc8c51
to
f02c790
Compare
|
Test results for linux-wpt-layout-2013 from try job (#5398571756): Flaky unexpected result (24)
Stable unexpected results that are known to be intermittent (13)
Stable unexpected results (9)
|
mrobinson
force-pushed
the
servo-2013-superset
branch
from
f02c790
to
6383e12
Compare
|
@bors-servo try=wpt |
bors-servo
added a commit
that referenced
this pull request
Jun 28, 2023
Make Layout 2013 style a superset of Layout 2020 style This is the first step toward removing the compile-time difference in style between Layout 2020 and Layout 2013. This change: - Adds `attr()` CSS content support to legacy layout - Adds parsing support for some unsupported features such as `display: flow-root` and `display: contents`. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
Test results for linux-wpt-layout-2013 from try job (#5401541356): Flaky unexpected result (13)
Stable unexpected results that are known to be intermittent (11)
Stable unexpected results (2)
|
|
💔 Test failed - checks-github |
This is the first step toward removing the compile-time difference in style between Layout 2020 and Layout 2013.
mrobinson
force-pushed
the
servo-2013-superset
branch
from
6383e12
to
d4b5fc1
Compare
|
@bors-servo try=wpt |
bors-servo
added a commit
that referenced
this pull request
Jun 28, 2023
Make Layout 2013 style a superset of Layout 2020 style This is the first step toward removing the compile-time difference in style between Layout 2020 and Layout 2013. This change: - Adds `attr()` CSS content support to legacy layout - Adds parsing support for some unsupported features such as `display: flow-root` and `display: contents`. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
Test results for linux-wpt-layout-2013 from try job (#5402080894): Flaky unexpected result (15)
Stable unexpected results that are known to be intermittent (12)
|
|
☀️ Test successful - checks-github |
Loirooriol
approved these changes
Jun 29, 2023
|
@bors-servo r=Loirooriol |
|
📌 Commit d4b5fc1 has been approved by |
|
Test results for linux-wpt-layout-2020 from try job (#5416099713): Flaky unexpected result (1)
|
|
Test results for linux-wpt-layout-2013 from try job (#5416099713): Flaky unexpected result (16)
Stable unexpected results that are known to be intermittent (9)
|
|
☀️ Test successful - checks-github |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step toward removing the compile-time difference in
style between Layout 2020 and Layout 2013. This change:
attr()CSS content support to legacy layoutdisplay: flow-rootanddisplay: contents../mach build -ddoes not report any errors./mach test-tidydoes not report any errors