-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move selector matching to an external library, for use outside Servo. #5010
Conversation
Critic review: https://critic.hoppipolla.co.uk/r/4053 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
To reviewers: this is mostly moving things around and fixing up The only significant change is that |
d5648bc
to
abbc1ef
Compare
The new library is https://github.com/servo/rust-selectors. It’s not quite ready for other users (the API needs work), but this is a first step. servo/rust-selectors#2 should also be reviewed. Fixes #3669.
|
Adding this change and squashing: --- a/components/style/stylesheets.rs
+++ b/components/style/stylesheets.rs
@@ -328,7 +328,7 @@ pub fn iter_font_face_rules<F>(stylesheet: &Stylesheet, device: &Device,
fn test_parse_stylesheet() {
use std::sync::Arc;
use cssparser;
- use selectors::*;
+ use selectors::parser::*;
use string_cache::Atom;
use properties::{PropertyDeclaration, DeclaredValue, longhands};
use std::borrow::ToOwned; |
abbc1ef
to
2a50755
Compare
The new library is https://github.com/servo/rust-selectors. It’s not quite ready for other users (the API needs work), but this is a first step. servo/rust-selectors#2 should also be reviewed. Fixes #3669.
The new library is https://github.com/servo/rust-selectors. It’s not quite ready for other users (the API needs work), but this is a first step.
servo/rust-selectors#2 should also be reviewed.
Fixes #3669.