Implement location.reload()

[paulrouget]

This is a naive implementation of window.location.reload().
I'd appreciate any feedback.

I was wondering if it'd be better to implement ConstellationMsg::Reload instead of using load_url.

Also, what kind of test should I write?

[highfive]

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @larsbergstrom (or someone else) soon.

[Ms2ger]

I'm not sure I want to add more naive navigation code, we already have way to much of that.

[paulrouget]

@Ms2ger said we should wait until he has rewritten all the navigation code

[Ms2ger]

-S-blocked-on-external +S-needs-tests +S-needs-rebase

Add some kind of wpt test?

---

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

---

Comments from the review on Reviewable.io

[paulrouget]

This is the only way I found to test location.reload(). Apparently, unload events and iframe.contentWindow don't work. So I used this hacky mechanism. Hope that's ok.

Also, ./mach test-wpt --manifest-update made some unrelated changes to tests/wpt/metadata/MANIFEST.json. Is that normal?

@Ms2ger r?

[Ms2ger]

LGTM, but avoid new JS features like const and () => {}.

[Ms2ger]

Sorry I missed this last time. You're creating multiple tests with the same name, which would be painful if we failed one of them. Please just put everything in one async_test, like:

async_test(function() {
  var url = new URL("./location_reload-iframe.html", window.location).href;
  ...
  window._ping = this.step_func(function() {
    ...
    assert_equals(url, innerURL, "iframe url");
    ...
    this.done();
  });

  iframe.src = url;
});

[paulrouget]

I don't know why, but this.step_func doesn't appear to work.

I use function(){this.step(…)} instead.

[paulrouget]

nvm, step_func works.

[paulrouget]

@Ms2ger review ping

[bors-servo]

☔ The latest upstream changes (presumably #7657) made this pull request unmergeable. Please resolve the merge conflicts.

[Ms2ger]

Sorry for the delay here.

@bors-servo r+

[bors-servo]

📌 Commit e742e7e has been approved by Ms2ger

[bors-servo]

⌛ Testing commit e742e7e with merge 4dc986b...

[bors-servo]

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt