Webdriver - GetWindowSize/IsEnabled/IsSelected

[craftytrickster]

Added handlers for #8623:
GetWindowSize
IsEnabled(WebElement)
IsSelected(WebElement)

I am not sure how to actually verify my webdriver code works, if someone can give advice I would make the necessary changes.

Thanks!

[highfive]

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @glennw (or someone else) soon.

[jdm]

r? @jgraham

[jgraham]

Looks mostly good. Unfortunately there isn't a easy way to test webdriver stuff because there doesn't exist a testsuite for the spec; I usually poke at it manually using the simple client I wrote for wptrunner. You can do this too, if you want; something like:

cd $SERVO_ROOT
source python/_virtualenv/bin/activate
./mach run [-d|-r] --webdriver 4444 &
cd tests/wpt/harness/wptrunner/executors
[i]python
import webdriver
session = webdriver.Session("127.0.0.1", 4444); session.start(); session.url = "about:blank";

and then look in webdriver.py to see more of the api that you can use. It doesn't fully implement the webdriver spec but it is rather simple to extend if you need. Sorry for the bad answer.

In any case I'll run this through its paces after the next round of fixups.

---

Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.

---

components/script/webdriver_handlers.rs, line 251 [r1] (raw file):
Indentation

---

components/script/webdriver_handlers.rs, line 259 [r1] (raw file):
Indentation

---

components/script/webdriver_handlers.rs, line 274 [r1] (raw file):
Indentation

---

components/webdriver_server/lib.rs, line 366 [r1] (raw file):
This should in fact be a WindowSizeResponse, which means you don't need to construct an interior JSON object, just set the width and height properties in the constructor.

---

Comments from the review on Reviewable.io

[craftytrickster]

Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

---

components/script/webdriver_handlers.rs, line 286 [r1] (raw file):
according to the spec, if it is not an input or option element, I should return false by default, not Err as I am doing here. I will add the extra step to check if it is a regular html element before the else { Err } branch.

---

Comments from the review on Reviewable.io

[craftytrickster]

Thanks @jgraham. I made the code changes you suggested. When I have time later I will look at the python test method you mentioned. I guess no repo is safe from the evil clutches of dynamically typed languages, not even Servo. 😄

[jgraham]

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from the review on Reviewable.io

[jgraham]

This seems to work fine. Before merging, would it be possible to get something more like an email address in the author field of the commit?

[craftytrickster]

Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks pending.

---

components/script/webdriver_handlers.rs, line 286 [r1] (raw file):
Done.

---

Comments from the review on Reviewable.io

[craftytrickster]

Just added email details to author, should be good to go.

[jgraham]

@bors-servo r+

[bors-servo]

📌 Commit 8d45107 has been approved by jgraham

[bors-servo]

⌛ Testing commit 8d45107 with merge a877a56...

[bors-servo]

☀️ Test successful - android, gonk, linux-dev, linux-rel, mac-dev-ref-unit, mac-rel-css, mac-rel-wpt