Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Wikipedia articles spend a lot of time in the AABB tree #32

Closed
pcwalton opened this issue Oct 15, 2015 · 2 comments
Closed

Some Wikipedia articles spend a lot of time in the AABB tree #32

pcwalton opened this issue Oct 15, 2015 · 2 comments

Comments

@pcwalton
Copy link
Contributor

For some reason we spend a lot of time in:

aabbtree::_$LT$impl$GT$::find_best_node::ha90e540da0edbf0bkjd

on http://en.wikipedia.org/wiki/Spotted_hyena

@glennw
Copy link
Member

glennw commented Oct 16, 2015

I noticed on some wikipedia pages there is a single display item at coordinates (0,100000) or similar. This can result in quite a large AABB tree. I tried to make it only split nodes where there is geometry but you still get quite a deep tree in these cases. It's probably worth checking if the time is due to something like that, then we can work out how to improve that.

@glennw
Copy link
Member

glennw commented Jan 29, 2016

I believe this is resolved - I changed the AABB tree to generate nodes lazily, so that you don't end up with huge amounts of empty nodes in edge cases.

@glennw glennw closed this as completed Jan 29, 2016
nox pushed a commit to nox/webrender that referenced this issue Aug 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants