Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support run-time selection between GL and GLES #771

Closed
sotaroikeda opened this issue Jan 24, 2017 · 1 comment
Closed

Support run-time selection between GL and GLES #771

sotaroikeda opened this issue Jan 24, 2017 · 1 comment

Comments

@sotaroikeda
Copy link
Contributor

Linked issue - servo/gleam#99

bors-servo pushed a commit that referenced this issue Mar 14, 2017
Use gl::Gl trait object in webrender

The pull request is preparation of #771. It just replace gleam::gl function calls with function calls to gleam::gl::Gl trait object.

API between winit and glutin is broken now. Then the pull request does not update glutin. The glutin still refers to old cgl and winit. It causes old gleam usage within them. Fixing the break is handled by rust-windowing/glutin#864.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/965)
<!-- Reviewable:end -->
bors-servo pushed a commit to servo/gleam that referenced this issue Mar 15, 2017
Fix GlesFns::get_type()

GlesFns::get_type() returns GlType::Gl now. It should be GlType::Gles.

The fix is related to servo/webrender#771.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/gleam/114)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Mar 15, 2017
Use Gl::get_type() to select Gl/Gles in WebRender

The pull request makes webrender dynamically switchable between GL and GLES.

It is related to #771

cc @kvark @glennw

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/984)
<!-- Reviewable:end -->
@glennw
Copy link
Member

glennw commented Mar 31, 2017

This happened!

@glennw glennw closed this as completed Mar 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants