Record time spent uploading in RendererStats #3275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, do we actually want to include gpu cache upload time? It is technically texture upload, but it's really more about sending parameters for the shaders, which is pretty separate from the images and such in the texture cache. If we're going to measure it, maybe we should measure it separately? |
|
+1 for measuring both separately. They are stressing the same bottleneck but they are different things to investigate. |
mattwoodrow
force-pushed
the
upload-time
branch
from
d8d81ba
to
469480b
Compare
|
Yeah that's probably a good idea, updated the pull to store the two values separately. Need to think about the best way to report these with gecko telemetry. |
mattwoodrow
force-pushed
the
upload-time
branch
from
469480b
to
438d999
Compare
mattwoodrow
force-pushed
the
upload-time
branch
from
438d999
to
8a1235e
Compare
|
@bors-servo r+ |
|
📌 Commit 8a1235e has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Nov 12, 2018
Record time spent uploading in RendererStats For gecko bug 1503405, we want to know the amount of time we spent doing texture uploads when drawing a frame. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3275) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-taskcluster |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For gecko bug 1503405, we want to know the amount of time we spent doing texture uploads when drawing a frame.
This change is