Fix coordinate space confusion in image::tiles. #3299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'result' was being computed as a size, but compared with leftover_offset which is a position. This changes us to work only with positions, and converts to a size at the end of the function.
|
r? @nical |
|
@bors-servo r+ |
|
📌 Commit fe49a2a has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Nov 12, 2018
Fix coordinate space confusion in image::tiles. 'result' was being computed as a size, but compared with leftover_offset which is a position. This changes us to work only with positions, and converts to a size at the end of the function. Addresses gecko bug 1506109. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3299) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-taskcluster |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'result' was being computed as a size, but compared with
leftover_offset which is a position.
This changes us to work only with positions, and converts to a size
at the end of the function.
Addresses gecko bug 1506109.
This change is