New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a RendererOption to configure if picture caching is enabled. #3367

Merged
merged 1 commit into from Nov 30, 2018

Conversation

Projects
None yet
3 participants
@gw3583
Collaborator

gw3583 commented Nov 28, 2018

Although not hooked up internally yet, this provides a hook so
that the gecko pref can be added.

We'll use this to provide a temporary way to compare performance
and also to allow picture caching to be disabled temporarily if
we encounter any bad regressions.


This change is Reviewable

Add a RendererOption to configure if picture caching is enabled.
Although not hooked up internally yet, this provides a hook so
that the gecko pref can be added.

We'll use this to provide a temporary way to compare performance
and also to allow picture caching to be disabled temporarily if
we encounter any bad regressions.
@gw3583

This comment has been minimized.

Collaborator

gw3583 commented Nov 28, 2018

@gw3583 gw3583 requested a review from kvark Nov 29, 2018

@gw3583

This comment has been minimized.

Collaborator

gw3583 commented Nov 29, 2018

(or @kvark or anyone really)

@kvark

This comment has been minimized.

Member

kvark commented Nov 30, 2018

@gw3583 it would be great to have 3 options here: force-enabled, force-disabled, and manual (specified per-SC). Your words got stuck in my head about the fact that picture caching is going to hide some of our performance issues, and this is worrying me. So I'd like to be able to constantly run without it to see how good our baseline is.

@kvark

This comment has been minimized.

Member

kvark commented Nov 30, 2018

Discussed on IRC a bit. Anyhow, this is harmless.
@bors-servo r+

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 30, 2018

📌 Commit d2e4f4c has been approved by kvark

@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 30, 2018

⌛️ Testing commit d2e4f4c with merge 4f95de4...

bors-servo added a commit that referenced this pull request Nov 30, 2018

Auto merge of #3367 - gw3583:pc-opt, r=kvark
Add a RendererOption to configure if picture caching is enabled.

Although not hooked up internally yet, this provides a hook so
that the gecko pref can be added.

We'll use this to provide a temporary way to compare performance
and also to allow picture caching to be disabled temporarily if
we encounter any bad regressions.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3367)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Contributor

bors-servo commented Nov 30, 2018

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: kvark
Pushing 4f95de4 to master...

@bors-servo bors-servo merged commit d2e4f4c into servo:master Nov 30, 2018

3 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Dec 1, 2018

WR Updater Bot
Bug 1511410 - Update webrender to commit 4f95de48bccbb06b44b03eae36f0…
…344a29b18678 (WR PR #3367). r=kats

servo/webrender#3367

Differential Revision: https://phabricator.services.mozilla.com/D13554

--HG--
extra : moz-landing-system : lando

mykmelez pushed a commit to mykmelez/gecko that referenced this pull request Dec 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment