Optimize the allocation of rasterized blobs a bit #3405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r=me, but can we add a comment explaining why the code is faster this way than using extend, so that someone doesn't accidentally regress it? |
|
@gw3583 my understanding is that |
|
Added a comment as requested. |
|
📌 Commit 074035c has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Dec 13, 2018
Optimize the allocation of rasterized blobs a bit Follow-up to #3398 Aimed to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1513521 Pending try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=26ea31fd69e8ed47167f33afefbd711424f0250a I think it's harmless either way, waiting to see if talos results are back to normal. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/3405) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-taskcluster |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Dec 13, 2018
…8970d1a90fe9 (WR PR #3405). r=kats servo/webrender#3405 Differential Revision: https://phabricator.services.mozilla.com/D14403 --HG-- extra : moz-landing-system : lando
mykmelez
pushed a commit
to mykmelez/gecko
that referenced
this pull request
Dec 14, 2018
…8970d1a90fe9 (WR PR #3405). r=kats servo/webrender#3405 Differential Revision: https://phabricator.services.mozilla.com/D14403
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…8970d1a90fe9 (WR PR #3405). r=kats servo/webrender#3405 Differential Revision: https://phabricator.services.mozilla.com/D14403 UltraBlame original commit: 29c74238cd77c77810351adc8d1d3b003f8d733a
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
…8970d1a90fe9 (WR PR #3405). r=kats servo/webrender#3405 Differential Revision: https://phabricator.services.mozilla.com/D14403 UltraBlame original commit: 29c74238cd77c77810351adc8d1d3b003f8d733a
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
…8970d1a90fe9 (WR PR #3405). r=kats servo/webrender#3405 Differential Revision: https://phabricator.services.mozilla.com/D14403 UltraBlame original commit: 29c74238cd77c77810351adc8d1d3b003f8d733a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #3398
Aimed to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1513521
Pending try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=26ea31fd69e8ed47167f33afefbd711424f0250a
I think it's harmless either way, waiting to see if talos results are back to normal.
This change is