Too much time passes between xrEndFrame() and xrWaitFrame() #96
Comments
This was referenced Nov 21, 2019
bors-servo
pushed a commit
that referenced
this issue
Nov 22, 2019
Always call wait_for_animation_frame after rendering Potential fix for #96 I need to profile things first to see if this improves anything. cc @asajeffrey
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
According to folks at Microsoft we're spending 12ms between
xrEndFrame()andxrWaitFrame(), which is potentially leading to low FPS.One potential fix is to always call
wait_for_animation_framejust after rendering. Currently we wait for script to send theRequestAnimationFramemessage before doing so. This is #97However, I would be surprised if there were any instances where there was a time delay between these anyway, because script currently unconditionally calls
request_animation_frameimmediately afterrender_animation_frameanyway. Perhaps the IPC is causing a delay, though.Furthermore, to be truly spec compliant, we shouldn't be waiting on script at all, the loop is just supposed to tick and send updated state to script, which is free to do things with it if it wishes (but it doesn't have to). This might be a bigger change.
cc @asajeffrey
The text was updated successfully, but these errors were encountered: