Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upopenxr: Remove GL readback from rendering. #79
Closed
+163
−298
Conversation
|
Requires pcwalton/surfman#32. |
|
TravisCI is failing because the tip of surfman is incompatible with the tip of surfman-chains (asajeffrey/surfman-chains#2) and we don't pin anything. |
|
|
|
Note that we're pinning to this on servo master, so if we rebase this we should do something to ensure the old commit sticks around. I recommend merging master into this branch |
|
Isn't it enough just to not delete the branch? |
|
Oh, I see what you mean. I'll open a new PR and leave this branch alone. |
|
Yes, but I find that to usually be fragile and prone to branch deletion. We
could use a tag.
On Clippy usually what we do is merge in backport branches with a one-sided
merge (thus adding it to the git history without causing change). In this
case a `git merge master` should be enough
…On Tue, Nov 5, 2019, 7:37 PM Josh Matthews ***@***.***> wrote:
Isn't it enough just to not delete the branch?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#79?email_source=notifications&email_token=AAMK6SGSMMYF3O7IPROZJ4LQSI3XDA5CNFSM4JIIYF62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDFEVCY#issuecomment-550128267>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMK6SCASXNTHLIOY57TX7DQSI3XDANCNFSM4JIIYF6Q>
.
|
bors-servo
added a commit
that referenced
this pull request
Nov 6, 2019
bors-servo
added a commit
that referenced
this pull request
Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedNov 2, 2019
These changes cause us to share the existing surfman device created by the webgl thread, rather than create a new one, because ANGLE refuses to share textures between different devices. In future we will want to make it possible for the webgl thread to allow the webxr device to create a surfman device, so that openxr can help us create a device with optimal settings, but this works in the short term.