Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openxr: Remove GL readback from rendering. #79

Closed
wants to merge 1 commit into from

Conversation

jdm
Copy link
Member

@jdm jdm commented Nov 2, 2019

These changes cause us to share the existing surfman device created by the webgl thread, rather than create a new one, because ANGLE refuses to share textures between different devices. In future we will want to make it possible for the webgl thread to allow the webxr device to create a surfman device, so that openxr can help us create a device with optimal settings, but this works in the short term.

@jdm
Copy link
Member Author

jdm commented Nov 2, 2019

Requires pcwalton/surfman#32.

@jdm
Copy link
Member Author

jdm commented Nov 4, 2019

TravisCI is failing because the tip of surfman is incompatible with the tip of surfman-chains (servo/surfman-chains#2) and we don't pin anything.

@bors-servo
Copy link
Contributor

☔ The latest upstream changes (presumably #82) made this pull request unmergeable. Please resolve the merge conflicts.

@Manishearth
Copy link
Member

Note that we're pinning to this on servo master, so if we rebase this we should do something to ensure the old commit sticks around. I recommend merging master into this branch

@jdm
Copy link
Member Author

jdm commented Nov 6, 2019

Isn't it enough just to not delete the branch?

@jdm
Copy link
Member Author

jdm commented Nov 6, 2019

Oh, I see what you mean. I'll open a new PR and leave this branch alone.

@jdm jdm closed this Nov 6, 2019
@Manishearth
Copy link
Member

Manishearth commented Nov 6, 2019 via email

bors-servo pushed a commit that referenced this pull request Nov 6, 2019
openxr: Remove GL readback from rendering.

Rebase of #79
bors-servo pushed a commit that referenced this pull request Nov 6, 2019
openxr: Remove GL readback from rendering.

Rebase of #79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants