-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openxr: Remove GL readback from rendering. #79
Conversation
Requires pcwalton/surfman#32. |
TravisCI is failing because the tip of surfman is incompatible with the tip of surfman-chains (servo/surfman-chains#2) and we don't pin anything. |
☔ The latest upstream changes (presumably #82) made this pull request unmergeable. Please resolve the merge conflicts. |
Note that we're pinning to this on servo master, so if we rebase this we should do something to ensure the old commit sticks around. I recommend merging master into this branch |
Isn't it enough just to not delete the branch? |
Oh, I see what you mean. I'll open a new PR and leave this branch alone. |
Yes, but I find that to usually be fragile and prone to branch deletion. We
could use a tag.
On Clippy usually what we do is merge in backport branches with a one-sided
merge (thus adding it to the git history without causing change). In this
case a `git merge master` should be enough
…On Tue, Nov 5, 2019, 7:37 PM Josh Matthews ***@***.***> wrote:
Isn't it enough just to not delete the branch?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#79?email_source=notifications&email_token=AAMK6SGSMMYF3O7IPROZJ4LQSI3XDA5CNFSM4JIIYF62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDFEVCY#issuecomment-550128267>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMK6SCASXNTHLIOY57TX7DQSI3XDANCNFSM4JIIYF6Q>
.
|
openxr: Remove GL readback from rendering. Rebase of #79
openxr: Remove GL readback from rendering. Rebase of #79
These changes cause us to share the existing surfman device created by the webgl thread, rather than create a new one, because ANGLE refuses to share textures between different devices. In future we will want to make it possible for the webgl thread to allow the webxr device to create a surfman device, so that openxr can help us create a device with optimal settings, but this works in the short term.