Skip to content

Conversation

jbsession
Copy link
Collaborator

SES-4564

On Android 14+, tapping the Pick form library button could loop back to the permission or select allowed media dialog instead of opening the gallery. This PR updates AttachmentManager.selectGallery() to recognize Android's partial photo access and open the gallery after selection.

partial_permission.mov

@jbsession jbsession self-assigned this Sep 15, 2025
@jbsession jbsession marked this pull request as ready for review September 15, 2025 02:39
@jbsession jbsession merged commit 8c43af7 into session-foundation:dev Sep 16, 2025
4 checks passed

// Android 14+ : if we already have partial OR full access, skip asking
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.UPSIDE_DOWN_CAKE) {
if (Permissions.hasAll(activity, Manifest.permission.READ_MEDIA_IMAGES) ||
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit worried about this, as we now might be missing some of the required permission, especially if this logic is also added to the avatars.
For example if someone gets the partial read_image permission from the avatars, then coming here to the attachment will return true which means the video and media_visual won't be requested and never will.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants