Skip to content

fix: macos + needs shift to be accessible #1579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2025
Merged

fix: macos + needs shift to be accessible #1579

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ts/hooks/useZoomingShortcut.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import useKey from 'react-use/lib/useKey';
import { ZOOM_FACTOR } from '../session/constants';
import { isMacOS } from '../OS';

const changeZoom = async (
change: { typeOfChange: 'delta'; delta: number } | { typeOfChange: 'reset' }
Expand All @@ -20,15 +21,17 @@ const changeZoom = async (

export function useZoomShortcuts() {
useKey(
event => (event.ctrlKey || event.metaKey) && (event.key === '+' || event.key === '='),
event =>
// macos + is accessible through shift only, so we need to allow `=` for macos
(event.ctrlKey || event.metaKey) && (event.key === '+' || (isMacOS() && event.key === '=')),
event => {
event.preventDefault();
void changeZoom({ typeOfChange: 'delta', delta: ZOOM_FACTOR.STEP });
}
);

useKey(
event => (event.ctrlKey || event.metaKey) && event.key === '-',
event => (event.ctrlKey || event.metaKey) && event.key === '-', // macos - is accessible without shift
event => {
event.preventDefault();
void changeZoom({ typeOfChange: 'delta', delta: -ZOOM_FACTOR.STEP });
Expand Down
Loading