-
Notifications
You must be signed in to change notification settings - Fork 0
fix: colors and gradients #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request includes updates to documentation content, layout improvements, and the addition of a GDPR compliance guide. The documentation updates focus on clarity and completeness, while the layout improvements enhance the visual appeal of the index page. Updated class diagram for table stylingclassDiagram
class th {
+background-color: var(--fd-secondary)
}
class global.css {
+table styling
}
th -- global.css : applies to
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @pmualaba - I've reviewed your changes and found some issues that need to be addressed.
Blocking issues:
- The Cluster API Password should not be hardcoded. (link)
- The Private Key should not be hardcoded. (link)
- The Pinning JWT Token should not be hardcoded. (link)
Overall Comments:
- The changes touch a lot of files, so make sure to test the impact on the overall documentation site.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🔴 Security: 3 blocking issues
- 🟢 Review instructions: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| **Credential** | **Description** | | ||
| ------------------------ | --------------------------------------------------- | | ||
| **Cluster API Username** | Identifies the IPFS cluster user. | | ||
| **Cluster API Password** | Required for **authentication**. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 issue (security): The Cluster API Password should not be hardcoded.
| **Cluster API Password** | Required for **authentication**. | | ||
| **Peer ID** | Unique identifier for the node in the IPFS network. | | ||
| **Public Key** | Used for **cryptographic verification**. | | ||
| **Private Key** | Enables secure **signing of IPFS transactions**. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 issue (security): The Private Key should not be hardcoded.
| **Peer ID** | Unique identifier for the node in the IPFS network. | | ||
| **Public Key** | Used for **cryptographic verification**. | | ||
| **Private Key** | Enables secure **signing of IPFS transactions**. | | ||
| **Pinning JWT Token** | Required for interacting with the **Pinning API**. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 issue (security): The Pinning JWT Token should not be hardcoded.
Summary by Sourcery
Fix formatting and remove trailing whitespaces across documentation files
Chores: