-
Notifications
You must be signed in to change notification settings - Fork 0
fix: update homepage atk link #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request includes several updates to the documentation, including adding a new step to the getting started guide, renaming the asset tokenization kit page, updating links, removing the meta.json file, and adding deployment and signup/login guides for the asset tokenization kit. Updated Flow Diagram for Smart Contract Developmentflowchart LR
A[Start] --> B{Setup private keys and attach them to a node for Tx Signer}
B --> C{Add Code Studio IDE}
C --> D{Develop smart contract code}
D --> E{Write test scripts and test contract}
E --> F{Compile smart contract and get ABI}
F --> G{Deploy contract to the network}
G --> H{Note the deployed contract address}
H --> I[End]
style A fill:#f9f,stroke:#333,stroke-width:2px
style I fill:#f9f,stroke:#333,stroke-width:2px
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @gyan-sharma - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using more descriptive image alt text for accessibility.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Review instructions: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@@ -10,6 +10,8 @@ Find the connection endpoint on the connect tab of the custom deployment Section | |||
Go to issuer portal, sign up to create the admin or the issuer account. The first user to signup gets the admin rights to the application. | |||
 | |||
|
|||
You may also setup sign-in via a passkey. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (typo): Consider rephrasing 'setup' to 'set up'.
Using the two-word phrasing 'set up' as a verb can improve clarity in the documentation.
You may also setup sign-in via a passkey. | |
You may also set up sign-in via a passkey. |
content/docs/index.mdx
Outdated
@@ -731,7 +731,7 @@ SettleMint Application Kits are designed to dramatically accelerate the | |||
development of enterprise blockchain applications by providing pre-packaged, | |||
full-stack solutions inlculding both - smart contrcats and the dAPP UI for common use cases. | |||
|
|||
Read more - [Aplication kits](/application-kits/asset-tokenization/asset-tokenization-kit) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick (typo): Check the spelling of 'Aplication kits' in the hyperlink text.
It appears that 'Aplication' might be missing a 'p'. If this change wasn’t intentional, consider correcting it to 'Application kits'.
Read more - [Aplication kits](/application-kits/asset-tokenization/asset-tokenization-kit) | |
Read more - [Application kits](/application-kits/introduction) |
Summary by Sourcery
Update documentation for the Asset Tokenization Kit, including restructuring pages, updating links, and adding new documentation pages for deployment and signup processes.
Enhancements:
Documentation: