Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add gas price arg if BTP_GAS_PRICE is set #3

Merged
merged 10 commits into from Mar 15, 2024
Merged

fix: add gas price arg if BTP_GAS_PRICE is set #3

merged 10 commits into from Mar 15, 2024

Conversation

snigdha920
Copy link
Contributor

@snigdha920 snigdha920 commented Mar 15, 2024 •
edited

  1. Sets the gas-price in the CLI if the env is set
  2. Fixed the GHA error:
docker exporter does not currently support exporting manifest lists

Currently we can't load multi arch images in the docker store (docker/build-push-action#733 (comment), old issue, but ref: docker/buildx#59, there are still issues); so we don't load the output and always push it

@github-actions github-actions bot added the fix label Mar 15, 2024
@roderik roderik merged commit 18bcebb into main Mar 15, 2024
1 check passed
@roderik roderik deleted the snigdha/eng-441-pass-gas-price-as-an-env-to-scs-interactive-mode-even-when branch March 15, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roderik roderik Awaiting requested review from roderik

@bl0up bl0up Awaiting requested review from bl0up

@SaeeDawod SaeeDawod Awaiting requested review from SaeeDawod

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@snigdha920 @roderik