FinalizeImplementation_195

sevntu-checkstyle · Aug 29, 2014 · 8e93de4 · 8e93de4
1 parent a817da2
commit 8e93de4
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 9 deletions.
diff --git a/...test/java/com/github/sevntu/checkstyle/checks/coding/FinalizeImplementationCheckTest.java b/...test/java/com/github/sevntu/checkstyle/checks/coding/FinalizeImplementationCheckTest.java
@@ -21,11 +21,11 @@ public final void basicTest() throws Exception
     {
 
         final String[] expected = {
-                "21: " + getCheckMessage(MSG_KEY_MISSED_TRY_FINALLY),
-                "34: " + getCheckMessage(MSG_KEY_MISSED_TRY_FINALLY),
-                "47: " + getCheckMessage(MSG_KEY_PUBLIC_FINALIZE),
-                "61: " + getCheckMessage(MSG_KEY_USELESS_FINALIZE),
-                "74: " + getCheckMessage(MSG_KEY_MISSED_SUPER_FINALIZE_CALL),
+                "22: " + getCheckMessage(MSG_KEY_MISSED_TRY_FINALLY),
+                "35: " + getCheckMessage(MSG_KEY_MISSED_TRY_FINALLY),
+                "48: " + getCheckMessage(MSG_KEY_PUBLIC_FINALIZE),
+                "62: " + getCheckMessage(MSG_KEY_USELESS_FINALIZE),
+                "75: " + getCheckMessage(MSG_KEY_MISSED_SUPER_FINALIZE_CALL),
             };
 
         verify(mCheckConfig,

diff --git a/...esources/com/github/sevntu/checkstyle/checks/coding/InputFinalizeImplementationCheck.java b/...esources/com/github/sevntu/checkstyle/checks/coding/InputFinalizeImplementationCheck.java
@@ -1,10 +1,11 @@
+package com.github.sevntu.checkstyle.checks.coding;
 class NormalFinalizer {
 
     public static void doStuff()
     {
         //This method do some stuff 
     }
-    protected void finalize()
+    protected void finalize() throws Throwable
     {
         try {
             doStuff(); 
@@ -44,7 +45,7 @@ public static void doStuff()
     {
         //This method do some stuff 
     }
-    public void finalize()
+    public void finalize() throws Throwable
     {
         try {
             doStuff(); 
@@ -65,13 +66,13 @@ protected void finalize() throws Throwable
 }
 
 //public finalizer
-class PublicFinalizer {
+class PublicFinalizer1 {
 
   public static void doStuff()
   {
       //This method do some stuff 
   }
-  protected void finalize()
+  protected void finalize() throws Throwable
   {
       try {
           doStuff();