Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade eclipse-cs version to 10.4 #930

Closed
rnveach opened this issue Nov 3, 2022 · 1 comment
Closed

Upgrade eclipse-cs version to 10.4 #930

rnveach opened this issue Nov 3, 2022 · 1 comment
Labels
approved
Milestone
1.43.0

Comments

@rnveach
Copy link
Contributor

rnveach commented Nov 3, 2022

Eclipse-cs has been making releases, so we need to update the version here.

We should wait to see if eclipse-cs goes all the way to 10.4.

When we do update, we need to make sure we are consistent with checkstyle/eclipse-cs#348 (comment) .
@rnveach rnveach changed the title Uprade eclipse-cs version Upgrade eclipse-cs version Nov 3, 2022
This was referenced Nov 13, 2022
Closed
Merged
romani pushed a commit that referenced this issue Nov 16, 2022
@rnveach @romani
Issue #930: upgrade to checkstyle 10.4
83a2bce
@romani romani changed the title Upgrade eclipse-cs version Upgrade eclipse-cs version to 10.4 Nov 16, 2022
@romani
Copy link
Member

romani commented Nov 16, 2022

Fix is merged

@romani romani closed this as completed Nov 16, 2022
@romani romani added this to the 1.43.0 milestone Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
1.43.0
Development

No branches or pull requests
2 participants
@romani @rnveach