Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #451: reworked travis and added PR desc testing #518

Merged
merged 1 commit into from
Dec 4, 2016

Conversation

rnveach
Copy link
Contributor

@rnveach rnveach commented Dec 4, 2016

Issue #451

@rnveach rnveach force-pushed the issue_451_2 branch 4 times, most recently from 476675c to a11c7f8 Compare December 4, 2016 01:54
@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.339% when pulling a11c7f8 on rnveach:issue_451_2 into c03e3d4 on sevntu-checkstyle:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.339% when pulling 9581524 on rnveach:issue_451_2 into c03e3d4 on sevntu-checkstyle:master.

@rnveach rnveach force-pushed the issue_451_2 branch 2 times, most recently from 109c459 to e9d7d10 Compare December 4, 2016 02:23
@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.339% when pulling e9d7d10 on rnveach:issue_451_2 into c03e3d4 on sevntu-checkstyle:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.339% when pulling d31c1dc on rnveach:issue_451_2 into c03e3d4 on sevntu-checkstyle:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.339% when pulling dca1384 on rnveach:issue_451_2 into c03e3d4 on sevntu-checkstyle:master.

@rnveach
Copy link
Contributor Author

rnveach commented Dec 4, 2016

@romani What do you think of this travis rewrite?
Before the build took 6 minutes. This build took 3 minutes.
The longest being eclipse-cs because of external downloads and sadly the other items need quick install of sevntu for further checking.

If it is all ok, I will squash and rename for #451 as this will include the PR testing.

@romani
Copy link
Member

romani commented Dec 4, 2016

good !
please prepare for merge.

side note and probably as next step idea:
review https://github.com/checkstyle/sonar-checkstyle/blob/master/.travis.yml , split of travis stuff into two files will give user ability to launch easily build item on his side.

@rnveach
Copy link
Contributor Author

rnveach commented Dec 4, 2016

@romani Squashed and renamed commit.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.339% when pulling 4362641 on rnveach:issue_451_2 into 1ca2b9f on sevntu-checkstyle:master.

@rnveach rnveach changed the title testing rewrite of travis Issue #451: reworked travis and added PR desc testing Dec 4, 2016
@romani romani merged commit b3f59ad into sevntu-checkstyle:master Dec 4, 2016
@romani
Copy link
Member

romani commented Dec 4, 2016

one day we need to question why we do "javadoc:javadoc" as separate step.
"mvn clean install" should be be enough.

@rnveach rnveach deleted the issue_451_2 branch December 4, 2016 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants