For query_typed, deal with the no-data case.
#1165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a query returns no data, we receive `Message::NoData`, which signals the completion of the query. However, we treated it as a no-op, leading to processing other messages and eventual failure. This PR fixes the issue and updates the `query_typed` tests to cover this scenario.
|
Thanks! |
1 similar comment
|
Thanks! |
ramnivas
added a commit
to exograph/exograph
that referenced
this pull request
Sep 18, 2024
With sfackler/rust-postgres#1165 merged and a new release with that change available in 0.7.12, we no longer need to use our fork. Compared to sfackler/rust-postgres#1147, there was a name change for `query_typed`, so this commit takes care of that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a query returns no data, we receive
Message::NoData, which signals the completion of the query. However, we treated it as a no-op, leading to processing other messages and eventual failure.This PR fixes the issue and updates the
query_typedtests to cover this scenario.