Add methods that take iterators of parameters #458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing methods which take slices of parameters work well when directly passing a temporary slice (e.g. `c.query(s, &[&15, &"hi"])`, but becomes limiting in other contexts like when programmatically building up a query. We now offer methods which take iterators, which are significantly more flexible for these kinds of use cases. Because of the weird object safety of `ToSql`, we can't be generic over `Iterator<Item = impl ToSql>`, but instead have to specifically work with `Iterator<Item = &dyn ToSql>`. This may require a `.map()` or two but should still work fine. Closes #265
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing methods which take slices of parameters work well when
directly passing a temporary slice (e.g.
c.query(s, &[&15, &"hi"]),but becomes limiting in other contexts like when programmatically
building up a query. We now offer methods which take iterators, which
are significantly more flexible for these kinds of use cases.
Because of the weird object safety of
ToSql, we can't be generic overIterator<Item = impl ToSql>, but instead have to specifically workwith
Iterator<Item = &dyn ToSql>. This may require a.map()or twobut should still work fine.
Closes #265